Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow disable the audio parsing/decoding/.. in DASH/HLS with a config #2196

Merged
merged 2 commits into from
Oct 22, 2019
Merged

Allow disable the audio parsing/decoding/.. in DASH/HLS with a config #2196

merged 2 commits into from
Oct 22, 2019

Conversation

avelad
Copy link
Member

@avelad avelad commented Oct 18, 2019

Resolves #2195

@avelad
Copy link
Member Author

avelad commented Oct 18, 2019

@joeyparrish If you are happy with the change, I'll proceed to create the tests

joeyparrish
joeyparrish reviewed Oct 18, 2019
View reviewed changes
Copy link
Member

@joeyparrish joeyparrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Once you've added tests, I'll run it through our build bot. Thanks!

@avelad
Copy link
Member Author

avelad commented Oct 22, 2019

@joeyparrish I have added the tests.

joeyparrish
joeyparrish approved these changes Oct 22, 2019
View reviewed changes
Copy link
Member

@joeyparrish joeyparrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks!

@shaka-bot
Copy link
Collaborator

All tests passed!

@joeyparrish joeyparrish merged commit 585c725 into shaka-project:master Oct 22, 2019
@joeyparrish joeyparrish mentioned this pull request Oct 31, 2019
Closed
TheModMaker pushed a commit that referenced this pull request Nov 6, 2019
@TheModMaker
Allow disable the audio parsing/decoding/.. in DASH/HLS with a config (…
68bf019 
…#2196)

Resolves #2195

Change-Id: If1381a21d8dc94c0d19f6c1d73a7eada021b5966
This was referenced Nov 28, 2019
Merged
Merged
@avelad avelad deleted the disable-audio branch December 12, 2019 15:30
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joeyparrish joeyparrish joeyparrish approved these changes

Assignees
No one assigned
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow disable the audio parsing/decoding/.. in DASH/HLS with a config
3 participants
@avelad @shaka-bot @joeyparrish