-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter image adaptation sets #2276
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could be good to have a test that tests that the parser will not error if there's an image track.
I added the test and the comment. Thanks @theodab |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM besides these last few nitpicks. Thanks for your contributions!
I'll run the buildbot now, since the changes I requested won't require changing the code significantly.
All tests passed! |
I changed the test name and the comment with the latest comments |
Alright, looks good. |
@theodab Can be included in the next release 2.5.x? Do you have any ETA for next release? |
* Filter image adaptation sets * Add comment about the change * Add test * Change Test name Change-Id: I80a16debd643d807ca61e132fe9d629c088e632a
This PR has been included in 2.5.7. |
Filter image DASH adaptation sets until #559 is resolved
Sample stream https://dash.akamaized.net/akamai/bbb_30fps/bbb_with_tiled_thumbnails_2.mpd
Now the error DASH_NO_SEGMENT_INFO is returned