Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter image adaptation sets #2276

Merged
merged 4 commits into from
Dec 6, 2019
Merged

Conversation

avelad
Copy link
Member

@avelad avelad commented Dec 4, 2019

Filter image DASH adaptation sets until #559 is resolved

Sample stream https://dash.akamaized.net/akamai/bbb_30fps/bbb_with_tiled_thumbnails_2.mpd

Now the error DASH_NO_SEGMENT_INFO is returned

Copy link
Contributor

@theodab theodab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be good to have a test that tests that the parser will not error if there's an image track.

lib/dash/dash_parser.js Show resolved Hide resolved
@avelad
Copy link
Member Author

avelad commented Dec 6, 2019

I added the test and the comment. Thanks @theodab

Copy link
Contributor

@theodab theodab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides these last few nitpicks. Thanks for your contributions!
I'll run the buildbot now, since the changes I requested won't require changing the code significantly.

test/dash/dash_parser_manifest_unit.js Outdated Show resolved Hide resolved
test/dash/dash_parser_manifest_unit.js Outdated Show resolved Hide resolved
@shaka-bot
Copy link
Collaborator

All tests passed!

@avelad
Copy link
Member Author

avelad commented Dec 6, 2019

I changed the test name and the comment with the latest comments

@theodab
Copy link
Contributor

theodab commented Dec 6, 2019

Alright, looks good.

@theodab theodab merged commit fcff08b into shaka-project:master Dec 6, 2019
@avelad
Copy link
Member Author

avelad commented Dec 10, 2019

@theodab Can be included in the next release 2.5.x? Do you have any ETA for next release?

@avelad avelad deleted the skip-thumbnails branch December 12, 2019 15:31
TheModMaker pushed a commit that referenced this pull request Dec 18, 2019
* Filter image adaptation sets

* Add comment about the change

* Add test

* Change Test  name

Change-Id: I80a16debd643d807ca61e132fe9d629c088e632a
@theodab
Copy link
Contributor

theodab commented Dec 19, 2019

This PR has been included in 2.5.7.

@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants