Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add corruptedFrames to stats #2328

Merged
merged 3 commits into from
Jan 10, 2020
Merged

Conversation

avelad
Copy link
Member

@avelad avelad commented Jan 7, 2020

No description provided.

Copy link
Member

@joeyparrish joeyparrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me otherwise. Thanks!

externs/shaka/player.js Outdated Show resolved Hide resolved
@avelad
Copy link
Member Author

avelad commented Jan 8, 2020

@joeyparrish Can you review it again?

externs/shaka/player.js Outdated Show resolved Hide resolved
@avelad
Copy link
Member Author

avelad commented Jan 9, 2020

@joeyparrish Can you review it again?

@shaka-bot
Copy link
Collaborator

All tests passed!

@theodab
Copy link
Contributor

theodab commented Jan 10, 2020

Looks good to me too.

@joeyparrish joeyparrish merged commit e0045e5 into shaka-project:master Jan 10, 2020
joeyparrish pushed a commit that referenced this pull request Jan 15, 2020
Backported to v2.5.x

Change-Id: I9f41cb20d7cbeb1652668fc138cf11036001a188
@joeyparrish
Copy link
Member

This PR has been cherry-picked for v2.5.8.

@avelad avelad deleted the corruptedFrames branch January 22, 2020 09:04
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants