-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add manifest.dash.ignoreEmptyAdaptationSet config option #2330
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I'll run the tests to verify it. Thanks for contributing!
All tests passed! |
I think that the PR doesn’t include demo locales. |
Oops! You're right. There's no definition for |
PR #2330 introduced a new option, but the actual message for the demo app was missing. This adds the missing message. Change-Id: Ia030925085af4e58299df0bd9c2417c6d2791a1b
I just landed a change to add the missing message. I have a test in review which would catch these mistakes in future. |
PR #2330 introduced a new message without a definition for it. This test would have caught the mistake in advance. Change-Id: I1a7b0fa2483b791b6b16405e55af84a49d100c83
Closes #2023 Backported to v2.5.x Change-Id: I3a0402e7f2caf46f72e4adee5e4eb82dfed332ef
This PR has been cherry-picked for v2.5.8. |
for #2023