Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add manifest.dash.ignoreEmptyAdaptationSet config option #2330

Merged
merged 1 commit into from
Jan 8, 2020

Conversation

leonchen
Copy link
Contributor

@leonchen leonchen commented Jan 8, 2020

for #2023

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@leonchen
Copy link
Contributor Author

leonchen commented Jan 8, 2020

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Copy link
Member

@joeyparrish joeyparrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I'll run the tests to verify it. Thanks for contributing!

@shaka-bot
Copy link
Collaborator

All tests passed!

@joeyparrish joeyparrish merged commit c6f0a86 into shaka-project:master Jan 8, 2020
@avelad
Copy link
Member

avelad commented Jan 8, 2020

I think that the PR doesn’t include demo locales.

@joeyparrish
Copy link
Member

Oops! You're right. There's no definition for DEMO_IGNORE_DASH_EMPTY_ADAPTATION_SET. We should add that, and come up with a test to catch those mistakes before they are merged.

shaka-bot pushed a commit that referenced this pull request Jan 8, 2020
PR #2330 introduced a new option, but the actual message for the demo
app was missing.  This adds the missing message.

Change-Id: Ia030925085af4e58299df0bd9c2417c6d2791a1b
@joeyparrish
Copy link
Member

I just landed a change to add the missing message. I have a test in review which would catch these mistakes in future.

shaka-bot pushed a commit that referenced this pull request Jan 9, 2020
PR #2330 introduced a new message without a definition for it.  This
test would have caught the mistake in advance.

Change-Id: I1a7b0fa2483b791b6b16405e55af84a49d100c83
@joeyparrish
Copy link
Member

Just landed the new test as well. Thanks to @leonchen for the PR, and to @avelad for pointing out the missing message.

joeyparrish pushed a commit that referenced this pull request Jan 15, 2020
Closes #2023

Backported to v2.5.x

Change-Id: I3a0402e7f2caf46f72e4adee5e4eb82dfed332ef
@joeyparrish
Copy link
Member

This PR has been cherry-picked for v2.5.8.

@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants