ban new Date.getTime() #2857
Merged
ban new Date.getTime() #2857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyparrish
approved these changes
Sep 17, 2020
|
All tests passed! |
matEhickey
pushed a commit
to matEhickey/shaka-player
that referenced
this pull request
Sep 25, 2020
Date.now should be used instead, to allow applications to monkey-patch it.
matEhickey
pushed a commit
to matEhickey/shaka-player
that referenced
this pull request
Sep 25, 2020
Date.now should be used instead, to allow applications to monkey-patch it.
joeyparrish
pushed a commit
that referenced
this pull request
Sep 29, 2020
Date.now should be used instead, to allow applications to monkey-patch it.
joeyparrish
pushed a commit
that referenced
this pull request
Oct 1, 2020
Date.now should be used instead, to allow applications to monkey-patch it. Backported to v2.5.x Change-Id: I40b287a4d39887d6b3ac9907e2233aec39c69add
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This request forces shaka-player to use
Date.now()for time calculations.First point here is that this is faster than
new Date().getTime().Second point is that it allows monkey-patching
Date.now()in runtime.We are having issues with using
Date.now()for time calculations (Date.nowis not monotonic because it's affected by system time changes).We are are going to monkey-patch
Date.now()by using offset returned byperformance.now()so it becomes monotonic and this patch makes this change consistent in our code and shaka-player.