Add LyRiCs (LRC) support #3036
Merged
Add LyRiCs (LRC) support #3036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joeyparrish Do you think it can be reviewed and include it in v3.1? |
This was referenced Dec 23, 2020
joeyparrish
requested changes
Dec 23, 2020
|
I will review it after my holidays (next week). thanks! |
|
@joeyparrish I have already reviewed all the comments. Can you review it again? |
added 3 commits
December 28, 2020 20:53
|
@joeyparrish I have already reviewed all the comments. Can you review it again? |
joeyparrish
reviewed
Dec 28, 2020
test/text/lrc_text_parser_unit.js
Outdated
Comment on lines
74
to
76
| '[00:30.1]Test4\n' + | ||
| '[00:40.001]Test5\n' + | ||
| '[00:50.02]Test6', |
There was a problem hiding this comment.
I think maybe these were meant to use commas as the decimal separator.
added 2 commits
December 28, 2020 22:15
joeyparrish
approved these changes
Dec 28, 2020
|
All tests passed! |
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add LyRiCs (LRC) support
Format info: https://en.wikipedia.org/wiki/LRC_(file_format)