Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Use simplified expression syntax #4046

Merged
merged 1 commit into from
Mar 21, 2022
Merged

ci: Use simplified expression syntax #4046

merged 1 commit into from
Mar 21, 2022

Conversation

joeyparrish
Copy link
Member

The "if" fields do not need to use expression syntax (${{ }}), and
some conditionals will be easier to read if we omit that.

The "if" fields do not need to use expression syntax (`${{ }}`), and
some conditionals will be easier to read if we omit that.
@joeyparrish joeyparrish requested a review from theodab March 21, 2022 21:17
@joeyparrish joeyparrish merged commit 218d05b into shaka-project:main Mar 21, 2022
@joeyparrish joeyparrish deleted the workflow-expressions branch March 21, 2022 22:31
joeyparrish added a commit that referenced this pull request Mar 22, 2022
The "if" fields do not need to use expression syntax (`${{ }}`), and
some conditionals will be easier to read if we omit that.

<!--
Please remember to:

1. Use Conventional Commits syntax (fix: ..., feat: ..., etc.) in commits and
   PR title (https://www.conventionalcommits.org/)
2. Tag any related or fixed issues ("Issue #123", "Closes #420")
3. Sign the Google CLA if you haven't (https://cla.developers.google.com)

You may delete this comment from the PR description.
-->
joeyparrish added a commit that referenced this pull request Mar 22, 2022
The "if" fields do not need to use expression syntax (`${{ }}`), and
some conditionals will be easier to read if we omit that.

<!--
Please remember to:

1. Use Conventional Commits syntax (fix: ..., feat: ..., etc.) in commits and
   PR title (https://www.conventionalcommits.org/)
2. Tag any related or fixed issues ("Issue #123", "Closes #420")
3. Sign the Google CLA if you haven't (https://cla.developers.google.com)

You may delete this comment from the PR description.
-->
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants