fix: Fix vanishing tracks while offline #4426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced in shaka-project#4189, as a side-effect of restricting tracks when a network failure occurs. We should not trigger such restrictions when the browser is known to be offline. Closes shaka-project#4408
JulianDomingo
approved these changes
Aug 18, 2022
| @@ -422,7 +422,6 @@ describe('Player', () => { | |||
| dispatchEventSpy.calls.reset(); | |||
| player.configure({streaming: {maxDisabledTime}}); | |||
| player.setMaxHardwareResolution(123, 456); | |||
| onErrorCallback(httpError); | |||
There was a problem hiding this comment.
Just to make sure I understand, was this line moved to the it() level since there's now a nested describe() scenario that also needs to call onErrorCallback(httpError) at the appropriate time in the jasmine test life cycle?
There was a problem hiding this comment.
Yes. The original author of these tests put onErrorCallback() in beforeEach(). But since that is the thing which triggers the code under test, it really belongs in the test itself. The rest can still be considered test setup.
This only became an issue when I wanted to nest another level with different setup. All setup needs to happen before the code under test is triggered.
theodab
approved these changes
Aug 18, 2022
|
Incremental code coverage: 100.00% |
avelad
pushed a commit
that referenced
this pull request
Aug 31, 2022
avelad
pushed a commit
that referenced
this pull request
Aug 31, 2022
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced in #4189, as a side-effect of restricting tracks when a
network failure occurs. We should not trigger such restrictions when
the browser is known to be offline.
Closes #4408