fix: WebVTT line not correctly positioned in UITextDisplayer (#4567) #4682
Conversation
…roject#4567) As stated in the specifications at https://w3c.github.io/webvtt/#webvtt-line-cue-setting and https://w3c.github.io/webvtt/#webvtt-cue-line-alignment the "end" modifier in the line alignment directive means that the box is positioned from the top of the screen but relatively to its bottom edge. The previous code actually positioned the box from the bottom of the screen.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
avelad
added
type: bug
|
Incremental code coverage: 60.00% |
There was a problem hiding this comment.
Overall, this looks correct. But before merging, I'm going to attempt to add a commit which creates a regression test, including screenshot comparisons generated in our lab.
If I can't figure out how to add that commit to your PR, I'll put it into a follow-up PR instead.
Thanks for the fix, and thanks for your patience!
|
New screenshots have been generated in the private lab for all supported platforms. When the GitHub test pass completes, I'll merge this PR. Thanks! |
I'm glad to help, and I know it's how open source works. Thanks to you for your dedication. |
…4682) As per spectification, [here](https://w3c.github.io/webvtt/#webvtt-line-cue-setting) and [there](https://w3c.github.io/webvtt/#webvtt-cue-line-alignment), my understanding is that a cue line with an optional alignment position `end`, e.g. `line:91%,end`, should have its bottom edge at 91% from the top of the screen. But the current code places it at 91% from the bottom of the screen. Fixes #4567 Co-authored-by: Rodolphe Breton <[email protected]> Co-authored-by: Joey Parrish <[email protected]>
…4682) As per spectification, [here](https://w3c.github.io/webvtt/#webvtt-line-cue-setting) and [there](https://w3c.github.io/webvtt/#webvtt-cue-line-alignment), my understanding is that a cue line with an optional alignment position `end`, e.g. `line:91%,end`, should have its bottom edge at 91% from the top of the screen. But the current code places it at 91% from the bottom of the screen. Fixes #4567 Co-authored-by: Rodolphe Breton <[email protected]> Co-authored-by: Joey Parrish <[email protected]>
…4682) As per spectification, [here](https://w3c.github.io/webvtt/#webvtt-line-cue-setting) and [there](https://w3c.github.io/webvtt/#webvtt-cue-line-alignment), my understanding is that a cue line with an optional alignment position `end`, e.g. `line:91%,end`, should have its bottom edge at 91% from the top of the screen. But the current code places it at 91% from the bottom of the screen. Fixes #4567 Co-authored-by: Rodolphe Breton <[email protected]> Co-authored-by: Joey Parrish <[email protected]>
github-actions
bot
added
the
status: archived
This PR intends to fix issue #4567.
As per spectification, here and there, my understanding is that a cue line with an optional alignment position
end, e.g.line:91%,end, should have its bottom edge at 91% from the top of the screen.But the current code places it at 91% from the bottom of the screen.