Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for segmentStartTime in vtt segments to handle live #481

Conversation

sanbornhilland
Copy link
Contributor

Closes #480

@sanbornhilland
Copy link
Contributor Author

This would fix #480 and not break VOD as far as I can see.

@baconz
Copy link
Contributor

baconz commented Aug 9, 2016

I do not think there is clarity on whether the cues should be relative or absolute for live playback. Can we put this behind a config parameter so we don't break backwards compatibility for those of us who have already hacked around this :)

See:

google/ExoPlayer#1493
Dash-Industry-Forum/Test-Vectors#44

@sanbornhilland
Copy link
Contributor Author

Okay, this what I was worried about. I was looking for information on how VTT segment timestamps were supposed to be reported but I couldn't find any. I guess this is why.

A config parameter would require us to know ahead of time whether the cues we were going to get back had relative or absolute timestamps which seems less than ideal. But if I understand you correctly you're saying there is no other indication from the manifest?

@sanbornhilland
Copy link
Contributor Author

I'm going to reject this for now because it seems evident that this solution is incomplete and requires some additional discussion first.

@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants