Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix surround sound test case on Tizen #4893

Merged
merged 1 commit into from
Jan 13, 2023

Conversation

joeyparrish
Copy link
Member

@joeyparrish joeyparrish commented Jan 13, 2023

This test started failing on Tizen after PR #4858, which updates codecs in manifest metadata any time they are rewritten. Since ac-3 is rewritten as ec-3 on Tizen, that caused this test case covering ac-3 to start failing (because the codec says ec-3 by the end of the test).

This test started failing on Tizen after PR shaka-project#4858.
@github-actions
Copy link
Contributor

Incremental code coverage: No instrumented code was changed.

@joeyparrish joeyparrish merged commit 3611f07 into shaka-project:main Jan 13, 2023
@joeyparrish joeyparrish deleted the fix-tizen-codec-test branch January 13, 2023 17:35
joeyparrish added a commit that referenced this pull request Jan 13, 2023
This test started failing on Tizen after PR #4858, which updates codecs
in manifest metadata any time they are rewritten. Since ac-3 is
rewritten as ec-3 on Tizen, that caused this test case covering ac-3 to
start failing (because the codec says ec-3 by the end of the test).
joeyparrish added a commit that referenced this pull request Jan 13, 2023
This test started failing on Tizen after PR #4858, which updates codecs
in manifest metadata any time they are rewritten. Since ac-3 is
rewritten as ec-3 on Tizen, that caused this test case covering ac-3 to
start failing (because the codec says ec-3 by the end of the test).
joeyparrish added a commit that referenced this pull request Jan 13, 2023
This test started failing on Tizen after PR #4858, which updates codecs
in manifest metadata any time they are rewritten. Since ac-3 is
rewritten as ec-3 on Tizen, that caused this test case covering ac-3 to
start failing (because the codec says ec-3 by the end of the test).
joeyparrish added a commit that referenced this pull request Jan 13, 2023
This test started failing on Tizen after PR #4858, which updates codecs
in manifest metadata any time they are rewritten. Since ac-3 is
rewritten as ec-3 on Tizen, that caused this test case covering ac-3 to
start failing (because the codec says ec-3 by the end of the test).
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants