Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Failed to set 'currentTime' property on 'HTMLMediaElement' on a Hisense TV #4962

Merged
merged 1 commit into from
Feb 3, 2023
Merged

fix: Failed to set 'currentTime' property on 'HTMLMediaElement' on a Hisense TV #4962

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/media/video_wrapper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,15 +135,15 @@ shaka.media.VideoWrapper = class {
// calling |Player.load|, meaning that |currentTime| is more meaningful than
// |startTime|.
//
// Seeking to the current time is a work around for Issue 1298. If we don't
// do this, the video may get stuck and not play.
// Seeking to the current time is a work around for Issue 1298 and 4888.
// If we don't do this, the video may get stuck and not play.
//
// TODO: Need further investigation why it happens. Before and after
// setting the current time, video.readyState is 1, video.paused is true,
// and video.buffered's TimeRanges length is 0.
// See: https://github.com/shaka-project/shaka-player/issues/1298
this.mover_.moveTo(
this.video_.currentTime == 0 ?
(!this.video_.currentTime || this.video_.currentTime == 0) ?
startTime :
this.video_.currentTime);
}
Expand Down