Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ads): Fix VMAP ads stay muted on muted autoplay #4995

Merged
merged 1 commit into from
Feb 13, 2023
Merged

fix(ads): Fix VMAP ads stay muted on muted autoplay #4995

merged 1 commit into from
Feb 13, 2023

Conversation

avelad
Copy link
Member

@avelad avelad commented Feb 11, 2023

Fixes #4992

@avelad avelad added type: bug Something isn't working correctly component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P2 Smaller impact or easy workaround labels Feb 11, 2023
@avelad avelad added this to the v4.4 milestone Feb 11, 2023
@github-actions
Copy link
Contributor

Incremental code coverage: 100.00%

@avelad avelad merged commit d074afc into shaka-project:main Feb 13, 2023
@github-actions github-actions bot mentioned this pull request Feb 13, 2023
Merged
@avelad avelad deleted the muted-vmap branch February 14, 2023 07:58
joeyparrish pushed a commit that referenced this pull request Mar 1, 2023
@avelad @joeyparrish
fix(ads): Fix VMAP ads stay muted on muted autoplay (#4995)
2b9ead2 
Fixes #4992
@github-actions github-actions bot mentioned this pull request Mar 1, 2023
Merged
joeyparrish pushed a commit that referenced this pull request Mar 1, 2023
@avelad @joeyparrish
fix(ads): Fix VMAP ads stay muted on muted autoplay (#4995)
c80c0bc 
Fixes #4992
@github-actions github-actions bot mentioned this pull request Mar 1, 2023
Merged
joeyparrish pushed a commit that referenced this pull request Mar 1, 2023
@avelad @joeyparrish
fix(ads): Fix VMAP ads stay muted on muted autoplay (#4995)
1d74f6e 
Fixes #4992
@github-actions github-actions bot mentioned this pull request Mar 1, 2023
Merged
joeyparrish pushed a commit that referenced this pull request Mar 2, 2023
@avelad @joeyparrish
fix(ads): Fix VMAP ads stay muted on muted autoplay (#4995)
4c5cf61 
Fixes #4992
@github-actions github-actions bot mentioned this pull request Mar 2, 2023
Merged
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

@littlespex littlespex Awaiting requested review from littlespex

Assignees
No one assigned
Labels
component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

VMAP ads stay muted on muted autoplay
2 participants
@avelad @theodab