Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(DASH): fix bufferBehind broken by thumbnails with TimelineSegmentIndex #5210

Merged
merged 1 commit into from
May 4, 2023
Merged

fix(DASH): fix bufferBehind broken by thumbnails with TimelineSegmentIndex #5210

merged 1 commit into from
May 4, 2023

Conversation

tykus160
Copy link
Member

@tykus160 tykus160 commented May 4, 2023

Similar to #4717 the same problem with broken bufferBehind occurs with the latest addition of TimelineSegmentIndex.

@avelad avelad added type: bug Something isn't working correctly priority: P2 Smaller impact or easy workaround component: DASH The issue involves the MPEG DASH manifest format labels May 4, 2023
@avelad avelad added this to the v4.4 milestone May 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023

Incremental code coverage: 100.00%

@theodab theodab merged commit 2d9f566 into shaka-project:main May 4, 2023
@theodab
Copy link
Contributor

theodab commented May 4, 2023

Thanks for your contribution.

@tykus160 tykus160 deleted the wt-bufferbehind-fix branch May 4, 2023 21:49
@github-actions github-actions bot mentioned this pull request May 4, 2023
Merged
@joeyparrish
Copy link
Member

This change did not cherry-pick cleanly to v4.2.x. If you think the fix is needed in v4.2.x, please create a new PR against that branch to backport it. (It didn't appear to be needed, but I could be mistaken.)

@joeyparrish
Copy link
Member

Same for v4.3.x

@tykus160
Copy link
Member Author

TimelineSegmentIndex is not ported to 4.2.x and 4.3.x, so nothing to backport here.

@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

@avelad avelad avelad approved these changes

@littlespex littlespex Awaiting requested review from littlespex

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

Assignees
No one assigned
Labels
component: DASH The issue involves the MPEG DASH manifest format priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@tykus160 @theodab @joeyparrish @avelad