Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(UI): Add thumbnails to the UI #5502

Merged
merged 10 commits into from
Aug 22, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
More simplifications
avelad committed Aug 22, 2023
commit 3827bad33806b6d683f557f4233f7a1c53a8fad4
7 changes: 7 additions & 0 deletions ui/range_element.js
Original file line number Diff line number Diff line change
@@ -119,6 +119,13 @@ shaka.ui.RangeElement = class extends shaka.ui.Element {
}
});

this.eventManager.listen(this.bar, 'blur', () => {
if (this.isChanging_) {
this.isChanging_ = false;
this.onChangeEnd();
}
});

this.eventManager.listen(this.bar, 'contextmenu', (e) => {
e.preventDefault();
e.stopPropagation();
7 changes: 0 additions & 7 deletions ui/seek_bar.js
Original file line number Diff line number Diff line change
@@ -181,13 +181,6 @@ shaka.ui.SeekBar = class extends shaka.ui.RangeElement {
this.showThumbnail_(mousePosition, value);
});

this.eventManager.listen(this.bar, 'blur', () => {
if (this.isMoving_) {
this.isMoving_ = false;
this.hideThumbnail_();
}
});

this.eventManager.listen(this.container, 'mouseleave', () => {
this.hideThumbnailTimer_.stop();
this.hideThumbnailTimer_.tickAfter(/* seconds= */ 0.25);