-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Webpack v2 and Yarn (#336) #367
Update to Webpack v2 and Yarn (#336) #367
Conversation
a193e1a
to
323dce3
Compare
@kaizencodes Great start. Looking forward to this one! |
323dce3
to
a782d07
Compare
Had to upgrade eslint-import-resolver-webpack. All good now. I believe this also solves #364. |
@justin808, I submitted PR #336 to resolve #364 before I saw this, feel free to ignore it if this fixes the issue. |
@kaizencodes @reconstructions I'm going to merge #336 first. Then let's apply this. Reviewed 21 of 21 files at r1. Comments from Reviewable |
a782d07
to
338b8e8
Compare
Odd files added. Reviewed 5 of 5 files at r2. client/package_BACKUP_3418.json, line 2 at r2 (raw file):
delete this file? client/package_BASE_3418.json, line 2 at r2 (raw file):
what's this file? Comments from Reviewable |
- Replaced npm calls to yarn - updated package.json to webpack and all dependencies - updated config files to use webpack2 syntax - updated docs - updated travis config for yarn
338b8e8
to
ddfba00
Compare
It must have been generated when I resolved the conflict, I didn't think it would do something like this. |
Reviewed 2 of 4 files at r3. Comments from Reviewable |
Great job @kaizencodes! Thanks! |
@justin808 @kaizencodes this PR broke hot-reloading with css-loader. Imported styles are not there anymore with Another issue is an error
which is printed out in log for every imported css module. Any suggestions how to fix these issues? |
Last one can be fixed by adding
|
@szyablitsky Please feel free to submit a PR. 😄 |
@Judahmeek is working on hot reloading. He can comment here. |
I'm not sure that using
There must be other way to provide |
@szyablitsky Yes, we should not be using the LoaderOptionsPlugin if we can avoid it. Are we using it in the /spec/dummy of the ReactOnRails repo? |
'sass', | ||
'sass-resources', | ||
use: [ | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'style-loader' is absent
hot reloading is not working because of it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@szyablitsky or @kaizencodes can you please submit a PR?
Eslint still fails due to the webpack resolver, couldn't solve it atm. I'll look into it later.
This change is