Updating ruby version and gem versions #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the build failed because of the style checks from Rubocop. It appears the upgraded ruby version/rubocop version triggered new style check offenses. @justin808 thoughts? |
|
Please try to address the rubocop issues.
|
tmobaird
force-pushed
the
maintenance/upgrade_dependency_versions
branch
from
2022e16 to
838bdac
Compare
|
@justin808 this should be good to go now. Besides updating the ruby version and gems, I had to update some of the source files, as well as the rubocop config, to fix new rubocop warnings that occurred after the version update. Let me know if there's anything else you'd like me to change! |
|
Let's update the npm libraries now! Thanks @tmobaird! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #382.
@justin808 here's the PR for updating the ruby version and gem versions. I chose to split the dependency updates up into two different PRs (one for each Ruby and JS) to help minimize any problems that are encountered.
The important stuff: I updated the ruby version to 2.4.1 and updated the gem versions.
The app is running just fine for me locally, and all the specs are passing as well. It should build just fine on travis, as long as ruby 2.4.1 is available on Travis's rvm (I believe it should be).
Feel free to let me know if there are any other changes you want me to make.
This change is