sync spec/dummy & generator webpacker config

lib/generators/react_on_rails/templates/base/base/config/webpack/development.js.tt

@@ -7,13 +7,10 @@ const { devServer, inliningCss } = require('@rails/webpacker');
 const webpackConfig = require('./webpackConfig');
 
 const developmentEnvOnly = (clientWebpackConfig, _serverWebpackConfig) => {
-  // eslint-disable-next-line no-unused-vars
-  const isWebpackDevServer = process.env.WEBPACK_DEV_SERVER;
-
   // plugins
   if (inliningCss) {
     // Note, when this is run, we're building the server and client bundles in separate processes.
-    // Thus, this plugin is not applied.
+    // Thus, this plugin is not applied to the server bundle.
 
     // eslint-disable-next-line global-require
     const ReactRefreshWebpackPlugin = require('@pmmmwh/react-refresh-webpack-plugin');
@@ -26,4 +23,5 @@ const developmentEnvOnly = (clientWebpackConfig, _serverWebpackConfig) => {
     );
   }
 };
+
 module.exports = webpackConfig(developmentEnvOnly);

lib/generators/react_on_rails/templates/base/base/config/webpack/serverWebpackConfig.js.tt

@@ -1,6 +1,5 @@
 <%= add_documentation_reference(config[:message], "// https://github.com/shakacode/react_on_rails_tutorial_with_ssr_and_hmr_fast_refresh/blob/master/config/webpack/serverWebpackConfig.js") %>
 
-// eslint-disable-next-line no-unused-vars
 const { merge, config } = require('@rails/webpacker');
 const commonWebpackConfig = require('./commonWebpackConfig');
 
@@ -31,7 +30,6 @@ const configureServer = () => {
   // replace file-loader with null-loader
   serverWebpackConfig.module.rules.forEach((loader) => {
     if (loader.use && loader.use.filter) {
-      // eslint-disable-next-line no-param-reassign
       loader.use = loader.use.filter(
         (item) => !(typeof item === 'string' && item.match(/mini-css-extract-plugin/)),
       );
@@ -69,11 +67,10 @@ const configureServer = () => {
   // Remove the mini-css-extract-plugin from the style loaders because
   // the client build will handle exporting CSS.
   // replace file-loader with null-loader
-  const { rules } = serverWebpackConfig.module;
+  const rules = serverWebpackConfig.module.rules;
   rules.forEach((rule) => {
     if (Array.isArray(rule.use)) {
       // remove the mini-css-extract-plugin and style-loader
-      // eslint-disable-next-line no-param-reassign
       rule.use = rule.use.filter((item) => {
         let testValue;
         if (typeof item === 'string') {
@@ -100,7 +97,6 @@ const configureServer = () => {
 
       // Skip writing image files during SSR by setting emitFile to false
     } else if (rule.use && (rule.use.loader === 'url-loader' || rule.use.loader === 'file-loader')) {
-      // eslint-disable-next-line no-param-reassign
       rule.use.options.emitFile = false;
     }
   });

lib/generators/react_on_rails/templates/base/base/config/webpack/test.js.tt

@@ -0,0 +1,13 @@
+<%= add_documentation_reference(config[:message], "// https://github.com/shakacode/react_on_rails_tutorial_with_ssr_and_hmr_fast_refresh/blob/master/config/webpack/development.js") %>
+
+process.env.NODE_ENV = process.env.NODE_ENV || 'development';
+
+const { devServer, inliningCss } = require('@rails/webpacker');
+
+const webpackConfig = require('./webpackConfig');
+
+const developmentEnvOnly = (clientWebpackConfig, _serverWebpackConfig) => {
+  // place any code here that is for test only
+};
+
+module.exports = webpackConfig(developmentEnvOnly);

spec/dummy/config/webpack/development.js

@@ -8,7 +8,7 @@ const developmentEnvOnly = (clientWebpackConfig, _serverWebpackConfig) => {
   // plugins
   if (inliningCss) {
     // Note, when this is run, we're building the server and client bundles in separate processes.
-    // Thus, this plugin is not applied.
+    // Thus, this plugin is not applied to the server bundle.
 
     // eslint-disable-next-line global-require
     const ReactRefreshWebpackPlugin = require('@pmmmwh/react-refresh-webpack-plugin');
@@ -21,4 +21,5 @@ const developmentEnvOnly = (clientWebpackConfig, _serverWebpackConfig) => {
     );
   }
 };
+
 module.exports = webpackConfig(developmentEnvOnly);

spec/dummy/config/webpack/production.js

@@ -1,7 +1,5 @@
 process.env.NODE_ENV = process.env.NODE_ENV || 'production';
 
-// Below code should get refactored but the current way that rails/webpacker v5
-// does the globals, it's tricky
 const webpackConfig = require('./webpackConfig');
 
 const productionEnvOnly = (_clientWebpackConfig, _serverWebpackConfig) => {