Merge pull request #229 from shakacode/fix-rake-task-names

Fix rake task names
shakacode · Jan 26, 2016 · b18a4cb · b18a4cb
2 parents 01cd5bc + 5184bb6
commit b18a4cb
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/rakelib/example_type.rb b/rakelib/example_type.rb
@@ -86,13 +86,12 @@ def rails_options
         "--skip-bundle --skip-spring --skip-git --skip-test-unit --skip-active-record"
       end
 
-      # Methods for retrieving the name of a task specific to the example type
       %w(gen prepare clean clobber npm_install build_webpack_bundles).each do |task_type|
-        method = "#{task_type}_task_name"      # ex: `clean_task_name`
-        task_name = "#{task_type}_#{name}"     # ex: `clean_basic`
+        method_name_normal = "#{task_type}_task_name"          # ex: `clean_task_name`
+        method_name_short = "#{method_name_normal}_short"      # ex: `clean_task_name_short`
 
-        define_method(method) { "#{self.class.namespace_name}:#{task_name}" }
-        define_method("#{method}_short") { task_name }
+        define_method(method_name_normal) { "#{self.class.namespace_name}:#{task_type}_#{name}" }
+        define_method(method_name_short) { "#{task_type}_#{name}" }
       end
 
       def rspec_task_name_short

diff --git a/spec/dummy/Gemfile.lock b/spec/dummy/Gemfile.lock
@@ -5,7 +5,7 @@ PATH
       connection_pool
       execjs (~> 2.5)
       rails (>= 3.2)
-      rainbow (~> 2.0)
+      rainbow (~> 2.1)
 
 GEM
   remote: https://rubygems.org/