Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update generators for proper jquery config #169

Closed
justin808 opened this issue Dec 22, 2015 · 4 comments
Closed

Update generators for proper jquery config #169

justin808 opened this issue Dec 22, 2015 · 4 comments

Comments

@justin808
Copy link
Member

Simple change to the generators: we don't need jquery-ujs for the webpack dev server.

This issue brought this to light: shakacode/react-webpack-rails-tutorial#185

@yorzi This should be a really simple change to make. Ping me if you need help.

@justin808
Copy link
Member Author

I did make this PR: shakacode/react-webpack-rails-tutorial#163. The Webpack Dev Server didn't need jquery-ujs.

@yorzi
Copy link
Contributor

yorzi commented Dec 27, 2015

@justin808 ok, what do you mean by "The Webpack Dev Server didn't need jquery-ujs" in this issue?

@yorzi
Copy link
Contributor

yorzi commented Dec 27, 2015

@justin808 I am supposed to see jquery-ujs in /templates/base/base/client/webpack.client.hot.config.js.tt right? I don't understand this issue now.

@justin808
Copy link
Member Author

You should not. the hot.config is for the webpack dev server, serving a "jade" template file (no rails). jquery-ujs is rails specific, so it only goes in the rails webpack configs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants