-
-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider integration with react-stdio for server rendering #183
Comments
Just for clarification, it's react-stdio, not react-studio :) On Mon, Jan 4, 2016 at 1:31 PM Justin Gordon [email protected]
|
@mjackson Thanks. Studio sounds kind of cool 😃. |
Probably the first step would be to create a Ruby wrapper for react-stdio that knows how to feed its stdin and parse its stdout. After that, integration with Rails should be fairly straightforward. |
I looked into implementing this into react_on_rails(and in react-rails). With our current server rendering method it's not going to work 'out of the box'. react-stdio takes a path to a component whereas we pass a string of JS code(with polyfills) to ExecJS(therubyracer). I ended up writing a little react-stdio wrapper for Rails that could be helpful in pursuing this option: https://github.com/aaronvb/rails_react_stdio. |
@aaronvb If you get this working, you will be a HERO |
@aaronvb any word on this one? |
@justin808 I haven't put much work into this. I'm open to pairing up or starting a branch for collaboration on this. |
@aaronvb Any progress on this one? We really should try this one! |
Closed by #380 |
@mjackson has created react-stdio. We should look into integrating this with react_on_rails.
@alexfedoseev: this looks promising
@cowboyd: Any thoughts on this compared to what we currently use: https://github.com/cowboyd/therubyracer
The text was updated successfully, but these errors were encountered: