Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSX template generator would be a nice feature #681

Closed
dmitrypol opened this issue Jan 13, 2017 · 8 comments
Closed

JSX template generator would be a nice feature #681

dmitrypol opened this issue Jan 13, 2017 · 8 comments

Comments

@dmitrypol
Copy link

I am still learning react_on_rails but one nice feature that react-rails has is ability to run generator and create JSX templates like this: rails g react:component User name:string ...

reast_on_rails hello_world generator is nice but copying and renaming all those files for what my application actually need is time consuming and error prone. Just a suggestion for a feature.

@justin808
Copy link
Member

See #245.

Contributions are encouraged!

@Luke-Popwell
Copy link

not sure if this is the right way to add to this, but i put this gem together yesterday to be able to add component and container generators to the react_on_rails gem. It's the first gem I've tried to build, but any feedback would be appreciated. https://rubygems.org/gems/redux-gem and heres the github link https://github.com/Luke-Popwell/redux-rails-gem

@justin808
Copy link
Member

@Luke-Popwell This would make a great PR to add to the generator. I can help you add this if you like. We've been planning on doing this for a while.

@Luke-Popwell
Copy link

Luke-Popwell commented Feb 12, 2017 via email

@Luke-Popwell
Copy link

Luke-Popwell commented Feb 12, 2017 via email

@justin808
Copy link
Member

Hi and thanks for getting back to me. I’d be more than happy to do that. being new to this would i get any credit for it? I’m just trying to get my first web development job lol

You'll be listed as a contributor! and you'll be in the https://github.com/shakacode/react_on_rails/blob/master/CHANGELOG.md!

@Luke-Popwell
Copy link

Luke-Popwell commented Feb 12, 2017 via email

@justin808
Copy link
Member

@Luke-Popwell Any luck with this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants