Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure the path is correctly escaped in case it contains spaces. #1045

Merged
merged 5 commits into from
Mar 31, 2018
Merged

Make sure the path is correctly escaped in case it contains spaces. #1045

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3831bba
Make sure the path is correctly escaped in case it contains spaces.
Mar 11, 2018
d9d1bf3
Wrap it in quotes instead of parsing it through a regex.
Mar 12, 2018
144ecba
Fix broken spec
Mar 23, 2018
eeb1e23
Merge remote-tracking branch 'upstream/master' into escape-path-fix
Mar 31, 2018
455b33e
Add changelog
Mar 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/react_on_rails/utils.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ def required(arg_name)
end

def self.prepend_cd_node_modules_directory(cmd)
"cd #{ReactOnRails.configuration.node_modules_location} && #{cmd}"
"cd #{Regexp::escape(ReactOnRails.configuration.node_modules_location.to_s)} && #{cmd}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this the right solution for shell escaping?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if put quotes around the value:

"cd \"#{ReactOnRails.configuration.node_modules_location}\" && #{cmd}"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea! Didn't think of that. I like that solution better!

end

def self.source_path
Expand Down