Remove ApplicationController.helpers prefix #1527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justin808
commented
Feb 28, 2023
lib/react_on_rails/helper.rb
Outdated
| @@ -327,7 +327,8 @@ def load_pack_for_component(component_name) | |||
| end | |||
|
|
|||
| ReactOnRails::WebpackerUtils.raise_nested_entries_disabled unless ReactOnRails::WebpackerUtils.nested_entries? | |||
|
|
|||
| puts "ZYXXYZ" if @self.nil? | |||
There was a problem hiding this comment.
why @self and not self?
There was a problem hiding this comment.
Because I only want line 330~331 to run the debug statement once.
Judahmeek
force-pushed
the
justin808/revert6753c84d
branch
from
8d867de to
f26cfe1
Compare
Judahmeek
changed the title
justin808
commented
Mar 18, 2023
.gitignore
Outdated
| @@ -19,8 +19,6 @@ | |||
|
|
|||
| node_modules | |||
|
|
|||
| /node_package/lib | |||
There was a problem hiding this comment.
Why are you removing this?
There was a problem hiding this comment.
These are the source files: https://github.com/shakacode/react_on_rails/tree/master/node_package/src
lib is generated.
There was a problem hiding this comment.
So I can test the branch without getting you to make a new release.
|
Please advise me if this is should be merged soon. |
Judahmeek
force-pushed
the
justin808/revert6753c84d
branch
from
ba0f480 to
f26cfe1
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 6753c84.
This is reverted to push out the release without this change.
This change is