Remove useless HMR=true from Procfile #1537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahangarha
force-pushed
the
remove-hmr-env-variable-from-procfile-in-install-template
branch
from
55e2d3b to
26ccf80
Compare
|
Update the changelog and I'll merge. |
justin808
approved these changes
May 12, 2023
justin808
approved these changes
May 12, 2023
justin808
deleted the
remove-hmr-env-variable-from-procfile-in-install-template
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove useless HMR=true from Procfile
Pull Request checklist
Remove this line after checking all the items here. If the item is not applicable to the PR, both check it out and wrap it by
~.Add/update test to cover these changesUpdate documentationOther Information
This PR is made based on the discussion with @justin808 on react_on_rails_demo_ssr_hmr upgrade.
This change is