Make sure renderInit only runs after DOMContentLoaded #1540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justin808
reviewed
May 28, 2023
justin808
reviewed
May 29, 2023
justin808
reviewed
May 29, 2023
node_package/src/clientStartup.ts
Outdated
| // If lazy asynch loading is used, such as with loadable-components, then the init | ||
| // function will install some handler that will properly know when to do hyrdation. | ||
| if (document.readyState !== 'loading') { | ||
| if (document.readyState === 'complete') { |
There was a problem hiding this comment.
This is the way the code used to be, which I changed in 7b301f9.
We need to ensure that we don't break the use case of loadable-components.
Maybe we should allow an opt-in to loading scripts so long as the readState !== 'loading'?
Romex91
reviewed
May 29, 2023
node_package/src/clientStartup.ts
Outdated
| // If lazy asynch loading is used, such as with loadable-components, then the init | ||
| // function will install some handler that will properly know when to do hyrdation. | ||
| if (document.readyState !== 'loading') { | ||
| if (document.readyState === 'complete') { | ||
| window.setTimeout(renderInit); | ||
| } else { | ||
| document.addEventListener('DOMContentLoaded', renderInit); |
There was a problem hiding this comment.
From MDN:
The DOMContentLoaded event fires when the initial HTML document has been completely loaded and parsed, without waiting for stylesheets, images, and subframes to finish loading.readyState === 'complete': The document and all sub-resources have finished loading. The state indicates that the load event is about to fire.
The event listener and the if statement correspond to different stages of page load.
Should it be something like the code below?
function onPageReady(callback) {
if (document.readyState === "complete") {
callback();
} else {
document.addEventListener("readystatechange", function onReadyStateChange() {
onPageReady(callback);
document.removeEventListener("readystatechange", onReadyStateChange);
});
}
}
There was a problem hiding this comment.
Yes, you're right, @Romex91.
Do you think this change, with your suggestions included, could cause any sort of performance regression for our clients?
Judahmeek
force-pushed
the
judahmeek/registration-fix
branch
from
84ad614 to
6739ecf
Compare
Judahmeek
force-pushed
the
judahmeek/registration-fix
branch
from
6739ecf to
a46fc0f
Compare
|
@Judahmeek this PR is ready to merge. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the race condition revealed by #1539
This change is