Define ReactOnRails only once #1559
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids multiple calls to ReactOnRails.register to override each other. Fixes #1558.
|
@rubenochiavone I Just wanted to say to be aware that the failure of CI tests is not because of your change. There is an issue with WebDrive. |
|
As it is, this is the worst kind of fix: the one that hides a true bug. This is worst than leaving the plain issue, which at least crashes. I'm OK with changing this PR to throw a clear error message that one has a problem loading the same bundle multiple times or incorrectly configured bundles including React on Rails multiple times. |
|
@rubenochiavone open a new PR per my prior comment. |
|
Done @justin808. See #1562. |
justin808
deleted the
rubenochiavone/fix-twice-components-crash-client-rendering
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This avoids multiple calls to ReactOnRails.register to override each other.
Fixes #1558.
Pull Request checklist
Remove this line after checking all the items here. If the item is not applicable to the PR, both check it out and wrap it by
~.Add the CHANGELOG entry at the top of the file.
This change is