-
-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce attw and drop React 17 support #1698
base: roman-kuksin/reduce-bundle-size
Are you sure you want to change the base?
Introduce attw and drop React 17 support #1698
Conversation
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
2b9e45a
to
eba5b39
Compare
@Judahmeek FYI, you may need to merge this PR to make |
Do you mean ESLint? |
No. |
@@ -43,11 +45,14 @@ | |||
"ts-jest": "^29.2.5", | |||
"typescript": "^5.6.2" | |||
}, | |||
"optionalDependencies": { | |||
"@arethetypeswrong/cli": "^0.17.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be in devDependencies
, it isn't a dependency of the package itself. And removed in the convert
script for Node 16 like
Line 19 in 923525d
gsub_file_content("../package.json", /"knip": "[^"]*",/, "") |
63c2d2d
to
fc42b26
Compare
Summary
Remove this paragraph and provide a general description of the code changes in your pull
request... were there any bugs you had fixed? If so, mention them. If
these bugs have open GitHub issues, be sure to tag them here as well,
to keep the conversation linked together.
Pull Request checklist
Remove this line after checking all the items here. If the item is not applicable to the PR, both check it out and wrap it by
~
.Add the CHANGELOG entry at the top of the file.
Other Information
Remove this paragraph and mention any other important and relevant information such as benchmarks.
This change is