Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change hide! to the implementation to support rails 3.2 #182

Merged
merged 4 commits into from
Jan 7, 2016
Merged

Change hide! to the implementation to support rails 3.2 #182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a58514e
Change hide! to the implementation to support rails 3.2
flynfish Jan 4, 2016
67b5dd3
Merge branch 'master' into rails_3.2_hide_generators
flynfish Jan 4, 2016
2ab00f8
Add parens for method call
flynfish Jan 4, 2016
0093f96
Remove redundent self calls
flynfish Jan 5, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/generators/react_on_rails/base_generator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
module ReactOnRails
module Generators
class BaseGenerator < Rails::Generators::Base # rubocop:disable Metrics/ClassLength
hide!
Rails::Generators.hide_namespace(namespace)
source_root(File.expand_path("../templates", __FILE__))

# --redux
Expand Down
2 changes: 1 addition & 1 deletion lib/generators/react_on_rails/bootstrap_generator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
module ReactOnRails
module Generators
class BootstrapGenerator < Rails::Generators::Base
hide!
Rails::Generators.hide_namespace(namespace)
source_root(File.expand_path("../templates", __FILE__))

def copy_bootstrap_files
Expand Down
2 changes: 1 addition & 1 deletion lib/generators/react_on_rails/dev_tests_generator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
module ReactOnRails
module Generators
class DevTestsGenerator < Rails::Generators::Base
hide!
Rails::Generators.hide_namespace(namespace)
source_root(File.expand_path("../templates/dev_tests", __FILE__))

def copy_rspec_files
Expand Down
2 changes: 1 addition & 1 deletion lib/generators/react_on_rails/heroku_deployment_generator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
module ReactOnRails
module Generators
class HerokuDeploymentGenerator < Rails::Generators::Base
hide!
Rails::Generators.hide_namespace(namespace)
source_root(File.expand_path("../templates", __FILE__))

def copy_heroku_deployment_files
Expand Down
2 changes: 1 addition & 1 deletion lib/generators/react_on_rails/js_linters_generator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
module ReactOnRails
module Generators
class JsLintersGenerator < Rails::Generators::Base
hide!
Rails::Generators.hide_namespace(namespace)
source_root File.expand_path("../templates", __FILE__)

# NOTE: linter modules are included via template in base/base/client/package.json.tt
Expand Down
2 changes: 1 addition & 1 deletion lib/generators/react_on_rails/react_no_redux_generator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
module ReactOnRails
module Generators
class ReactNoReduxGenerator < Rails::Generators::Base
hide!
Rails::Generators.hide_namespace(namespace)
source_root(File.expand_path("../templates", __FILE__))

# --server-rendering
Expand Down
2 changes: 1 addition & 1 deletion lib/generators/react_on_rails/react_with_redux_generator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
module ReactOnRails
module Generators
class ReactWithReduxGenerator < Rails::Generators::Base
hide!
Rails::Generators.hide_namespace(namespace)
source_root(File.expand_path("../templates", __FILE__))

# --server-rendering
Expand Down
2 changes: 1 addition & 1 deletion lib/generators/react_on_rails/ruby_linters_generator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
module ReactOnRails
module Generators
class RubyLintersGenerator < Rails::Generators::Base
hide!
Rails::Generators.hide_namespace(namespace)
source_root File.expand_path("../templates", __FILE__)

def add_ruby_linter_gems_to_gemfile
Expand Down