Allow using nested entries #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomdracz
requested changes
May 21, 2022
| @@ -8,6 +8,9 @@ Changes since last non-beta release. | |||
|
|
|||
| *Please add entries here for your pull requests that are not yet released.* | |||
|
|
|||
| ## Added | |||
| - Configuration boolean option `nested_entries` to use nested entries. This was the default prior to v6.0. Because entries maybe generated, it's useful to allow a `generated` subdirectory. | |||
|
|
|||
There was a problem hiding this comment.
@justin808 can we add something in the readme suggesting when you would want to use that and examples?
| @@ -34,7 +37,7 @@ Note: [Rubygem is 6.3.0.pre.rc.1](https://rubygems.org/gems/shakapacker/versions | |||
| ### Improved | |||
| - Use last modified timestamps rather than file digest to determine compiler freshness. [PR 97](https://github.com/shakacode/shakapacker/pull/97) by [tomdracz](https://github.com/tomdracz). | |||
|
|
|||
| Rather than calculating SHA digest of all the files in the paths watched by the compiler, we are now comparing the modified time of the `manifest.json` file versues the latest modified timestamp of files and directories in watched paths. Unlike calculating digest, which only looked at the files, the new calculation also considers directory timestamps, including the parent ones (i.e. `config.source_path` folder timestamp will be checked together will timestamps of all files and directories inside of it). | |||
| Rather than calculating SHA digest of all the files in the paths watched by the compiler, we are now comparing the modified time of the `manifest.json` file versus the latest modified timestamp of files and directories in watched paths. Unlike calculating digest, which only looked at the files, the new calculation also considers directory timestamps, including the parent ones (i.e. `config.source_path` folder timestamp will be checked together will timestamps of all files and directories inside of it). | |||
| }) | ||
|
|
||
| test('should return 3 entry points with config.nested_entries == true', () => { | ||
| expect(baseConfig.entry.multi_entry.length).toEqual(2) |
There was a problem hiding this comment.
Test description is saying it will return 3 entrypoints but test expectation is matching length of 2 🤔 Something is not quite right here
tomdracz
reviewed
May 25, 2022
| resolve('app', 'packs', 'entrypoints', 'multi_entry.js') | ||
| ]) | ||
| expect(baseConfig.entry['generated/something']).toEqual( | ||
| resolve('app', 'packs', 'entrypoints', 'generated', 'something.js') |
There was a problem hiding this comment.
Looks like this is failing ATM
Nested entries were removed in v6.0. This PR allows using them with a configuration switch. By default they are turned off.
|
@tomdracz did I get all your feedback? |
tomdracz
reviewed
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nested entries were removed in v6.0.
This PR allows using them with a configuration switch.
By default they are turned off.