Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move compilation lock file into the working directory #272

Merged
merged 3 commits into from
Apr 5, 2023

Conversation

tomdracz
Copy link
Collaborator

Summary

Fixes #158

Potentially addresses #269 ?

Moves shakapacker.lock file from system tmp dir into project tmp directory.

Pull Request checklist

  • Update CHANGELOG file

@tomdracz tomdracz requested a review from justin808 March 31, 2023 13:58
Copy link
Member

@justin808 justin808 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Does a test hit this code?

@justin808
Copy link
Member

@tomdracz one question, plus need to resolve conflicts.

@tomdracz tomdracz force-pushed the make-lock-file-local branch from c46ab3d to 21c762a Compare April 4, 2023 11:06
@tomdracz
Copy link
Collaborator Author

tomdracz commented Apr 4, 2023

@justin808 Conflict resolved, tests that are run using spec/test_app will hit those code paths

@tomdracz tomdracz merged commit 80d784a into master Apr 5, 2023
@tomdracz tomdracz deleted the make-lock-file-local branch April 5, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The webpacker compilation lock is global
3 participants