Remove @babel/preset-typescript defaults #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahangarha
approved these changes
Apr 1, 2023
There was a problem hiding this comment.
Thanks,
My only concern is related to the Shakapacker version for this change to be applied.
@justin808
Should we have this for version 7 or version 6? As per your comment, I think it is better to have this for version 6.
With this being potentially breaking, I would keep it for v7 probably. Have we got any other stuff to go into v6? |
tomdracz
added a commit
that referenced
this pull request
Apr 18, 2023
* Remove default options passed to @babel/preset-typescript
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #267
I was thinking of doing something similar to SWC rules https://github.com/shakacode/shakapacker/blob/master/package/swc/index.js#L28-L33 but in the end decided it brings no value realistically.
The setting in SWC to figure out config from the file was added to go around the limitations there, Babel should be already correctly figuring out file types and behaviour from the extensions with the default preset settings.
Pull Request checklist
_Remove this line after checking all the items here. If the item is not applicable to the PR, both check it out and wrap it by
Add the CHANGELOG entry at the top of the file.