fix: use NODE_OPTIONS
instead of calling node
directly for debugging
#350
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently debugging options for
node
are handled by switching to callingnode
which is fine except requires the absolute path to the javascript file to execute to be passed which isn't what happens ifnode_modules_bin_exist?
is false because that falls back to justyarn webpack
andyarn webpack serve
:This switches to providing those options using the
NODE_OPTIONS
env variable instead, which should ensure the options are always enabled regardless of how the desired commands are invoked.This change also makes #349 / #195 a little easier.
Pull Request checklist
Other Information
I have tested this locally using
NODE_OPTIONS="--unhandled-rejections=warn"
and having aPromise.reject()
in the webpack config - I've not added any test cases since none exist already for this section, and it's a bit tricky to automate for the test suite.