Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conda recipe #90

Closed
sarthakpati opened this issue Jul 15, 2021 · 10 comments · Fixed by #95
Closed

Add conda recipe #90

sarthakpati opened this issue Jul 15, 2021 · 10 comments · Fixed by #95
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@sarthakpati
Copy link
Contributor

Describe the new feature:

It would be great to have a conda recipe so that it can be included with projects that have more complicated build processes (for example, using libraries that need C/C++ compilers).

What is the current outcome?

Have a recipe for dython on the conda-forge channel.

Is it backward-compatible?

Yes, and it would be forward-compatible as well, because the conda bots can automatically fetch new sdists pushed to pypi.

@sarthakpati sarthakpati added the enhancement New feature or request label Jul 15, 2021
@sarthakpati
Copy link
Contributor Author

I am already working on this: conda-forge/staged-recipes#15632

Happy to add anyone needed as a maintainer.

@shakedzy
Copy link
Owner

Hey @sarthakpati ! That's an excellent idea. As I don't use Conda, I doubt if I can assist here - but seems like you're on it yourself :) let me know if there's anything specific I can assist with.

@shakedzy shakedzy added the help wanted Extra attention is needed label Jul 17, 2021
@sarthakpati
Copy link
Contributor Author

I am happy to take this on. #91 would be the first step towards this. 😄

sarthakpati added a commit to sarthakpati/dython that referenced this issue Jul 25, 2021
@shakedzy
Copy link
Owner

Hey @sarthakpati ! Seems like everything is set up - great work! thanks :) As I'm not using Conda, and less aware of how it works, I'll ask you - when a new version is released, what needs to be done in order to push it to Conda? At the moment I'm using Github Actions to automatically deploy any new version of Dython directly to PyPI. What do I need to add?

@sarthakpati
Copy link
Contributor Author

You don't need to do anything. Conda bots pick up the new version from pip and put the PR by themselves. 😄

@shakedzy
Copy link
Owner

Amazing work. Thanks!

@shakedzy
Copy link
Owner

I'm away from my laptop, and I'd like to add the new conda installation instructions to the website too. As this requires a mkdocs build, I'll be able to merge this PR only next week.. Thanks again, awesome work!

shakedzy added a commit that referenced this issue Aug 1, 2021
@shakedzy
Copy link
Owner

shakedzy commented Aug 1, 2021

Done! @sarthakpati , thanks a lot - your name now appears on the Change-Log :)

@shakedzy
Copy link
Owner

shakedzy commented Sep 6, 2021

@sarthakpati it seems the new versions are not noticed by Conda.. any idea?

@shakedzy shakedzy reopened this Sep 6, 2021
@shakedzy
Copy link
Owner

shakedzy commented Sep 6, 2021

My bad, it does. The Conda badge doesn't display the post2 suffix for some reason..

@shakedzy shakedzy closed this as completed Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants