shalika10|PrefectHQ#3306|Fix environments -storage module for explici…

…t chaining
shalika10 · Oct 8, 2020 · 1b14314 · 1b14314
1 parent cb31eab
commit 1b14314
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/changes/issue3306.yaml b/changes/issue3306.yaml
@@ -2,4 +2,5 @@ enhancement:
     - "Use explicit exception chaining - [#3306](https://github.com/PrefectHQ/prefect/issues/3306)"
 
 contributor:
-    - "[Aaron Richter](https://github.com/rikturr)"
+    - "[Aaron Richter](https://github.com/rikturr)"
+    - "[Shalika Singhal](https://github.com/shalika10)"
diff --git a/src/prefect/environments/storage/_healthcheck.py b/src/prefect/environments/storage/_healthcheck.py
@@ -122,12 +122,12 @@ def environment_dependency_check(flows: list):
         for dependency in required_imports:
             try:
                 importlib.import_module(dependency)
-            except ModuleNotFoundError:
+            except ModuleNotFoundError as moduleNotFoundError:
                 raise ModuleNotFoundError(
                     "Using {} requires the `{}` dependency".format(
                         flow.environment.__class__.__name__, dependency
                     )
-                )
+                ) from moduleNotFoundError
 
     print("Environment dependency check: OK")
 

diff --git a/src/prefect/environments/storage/webhook.py b/src/prefect/environments/storage/webhook.py
@@ -35,12 +35,12 @@ def __getitem__(self, key: str) -> str:
         if out is None:
             try:
                 out = Secret(key).get()
-            except ValueError:
+            except ValueError as valueError:
                 msg = (
                     "Template value '{}' does not refer to an "
                     "environment variable or Prefect secret."
                 )
-                raise RuntimeError(msg.format(key))
+                raise RuntimeError(msg.format(key)) from valueError
         return out  # type: ignore
 
     def __iter__(self) -> Iterator[Any]: