pallet-tips | port to frame v2 #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Change companion check order Apparently if the pr isn't approved it counts as not mergable. However, this is rahter confusing. To fix this, we just change the order. * Move exit
…-tips-port-frame-v4 merge to upstream master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pallet-tips | port to frame v2
related paritytech#7882 | Has dependency on paritytech#8196 , paritytech#8193
From https://crates.parity.io/frame_support/attr.pallet.html#checking-upgrade-guidelines
So users of the treasury pallet must be careful about the name they used in construct_runtime!. Hence, the runtime-migration label, which might not be needed depending on the configuration of the treasury pallet.