Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Test against XGBoost 2.0 #3256

Closed
2 tasks done
connortann opened this issue Sep 13, 2023 · 1 comment · Fixed by #3257
Closed
2 tasks done

ENH: Test against XGBoost 2.0 #3256

connortann opened this issue Sep 13, 2023 · 1 comment · Fixed by #3257
Labels
dependencies Pull requests that update a dependency file enhancement Indicates new feature requests
Milestone
0.44.0

Comments

@connortann
Copy link
Collaborator

connortann commented Sep 13, 2023 •
edited
Loading

Problem Description

The tests are failing with XGBoost 2.0, as per #3254 . A short-term fix could be to just pin the previous version.

This issue however is to get our test suite passing against the latest version, which I think would be a preferable long-term solution:
https://github.com/dmlc/xgboost/releases/tag/v2.0.0

Feature request checklist

  • I have checked the issue tracker for duplicate issues.
  • I'd be interested in making a PR to implement this feature
@connortann connortann added enhancement Indicates new feature requests dependencies Pull requests that update a dependency file labels Sep 13, 2023
This was referenced Sep 13, 2023
Merged
Merged
Closed
@connortann connortann changed the title ENH: Get tests passing on XGBoost 2.0 ENH: Test against XGBoost 2.0 Sep 13, 2023
@connortann connortann added this to the 0.44.0 milestone Sep 29, 2023
@CloseChoice CloseChoice mentioned this issue Oct 4, 2023
Closed
2 tasks
@connortann
Copy link
Collaborator Author

Related issue in XGBoost, from #3307 (comment) :

dmlc/xgboost#8345

https://github.com/dmlc/xgboost/blob/4d7a187cb0ebc2194abc1efe0aaee6f06af937c5/tests/python/test_with_shap.py#L16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file enhancement Indicates new feature requests
Projects
None yet
Milestone
0.44.0
1 participant
@connortann