Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Fix failing tests, pin XGBoost in test dependencies to 1.7.6 #3255

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

connortann
Copy link
Collaborator

@connortann connortann commented Sep 13, 2023

Overview

Closes #3254

Pins XGBoost in test dependencies to 1.7.6.

Context

The baseline images we have are signifcantly altered in XGBoost 2.0.0. So, pinning the test dependency to the last working version seems like a pragmatic short-term fix to get the tests working again.

Once the tests are fixed, we should consider:

@connortann connortann added dependencies Pull requests that update a dependency file ci Relating to Continuous Integration / GitHub Actions labels Sep 13, 2023
@connortann connortann changed the title Fix failing tests: pin XGBoost in test dependencies to 1.7.6 MAINT: Fix failing tests, pin XGBoost in test dependencies to 1.7.6 Sep 13, 2023
@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Patch coverage has no change and project coverage change: +17.44% 🎉

Comparison is base (e8a176e) 40.16% compared to head (d43698e) 57.61%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #3255       +/-   ##
===========================================
+ Coverage   40.16%   57.61%   +17.44%     
===========================================
  Files          88       88               
  Lines       12510    12511        +1     
===========================================
+ Hits         5025     7208     +2183     
+ Misses       7485     5303     -2182     

see 33 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@connortann connortann marked this pull request as ready for review September 13, 2023 22:59
@connortann
Copy link
Collaborator Author

connortann commented Sep 14, 2023

@dsgibbons , @thatlittleboy , would you kindly take a look and review? It would be good fix the tests, so other PRs are not blocked.

Copy link
Collaborator

@dsgibbons dsgibbons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, seems like a sensible fix for now

@dsgibbons dsgibbons merged commit 96467db into master Sep 15, 2023
@connortann connortann deleted the fix-3254 branch September 15, 2023 09:23
@connortann connortann added the skip-changelog PRs that should be excluded from the changelog label Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Relating to Continuous Integration / GitHub Actions dependencies Pull requests that update a dependency file skip-changelog PRs that should be excluded from the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: CI Tests failing since XGBoost 2.0.0 release
2 participants