This repository has been archived by the owner on Apr 11, 2023. It is now read-only.
fix: speed up invert of generated caip info #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elmutt
approved these changes
Nov 27, 2021
0xdef1cafe
approved these changes
Nov 29, 2021
|
my bad as i didn't intend this path to get hit at runtime, just generate, good catch |
shapeshift-ci-bot
pushed a commit
that referenced
this pull request
Nov 29, 2021
# [@shapeshiftoss/caip-v1.4.2](https://github.com/shapeshift/lib/compare/@shapeshiftoss/caip-v1.4.1...@shapeshiftoss/caip-v1.4.2) (2021-11-29) ### Bug Fixes * speed up invert of generated caip info ([#256](#256)) ([b7d58e4](b7d58e4))
|
🎉 This PR is included in version @shapeshiftoss/caip-v1.4.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is, as far as I can tell, the biggest culprit in the Case of the Slow Page Load; the object allocation is high-overhead by itself, but the spread operator also gets transpiled down to use a babel shim that allocates extra temporary arrays of the intermediate objects' properties and loops over them.