This repository has been archived by the owner on Apr 11, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c73e6d2
to
a608dd6
Compare
a608dd6
to
0c08062
Compare
0xdef1cafe
reviewed
Dec 14, 2021
0xdef1cafe
reviewed
Dec 16, 2021
0xdef1cafe
reviewed
Dec 16, 2021
0xdef1cafe
reviewed
Dec 17, 2021
0xdef1cafe
suggested changes
Dec 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bnOrZero in one more spot
0xdef1cafe
approved these changes
Dec 17, 2021
0xdef1cafe
approved these changes
Dec 17, 2021
elmutt
approved these changes
Dec 17, 2021
shapeshift-ci-bot
pushed a commit
that referenced
this pull request
Dec 17, 2021
# [@shapeshiftoss/types-v1.20.0](https://github.com/shapeshift/lib/compare/@shapeshiftoss/types-v1.19.1...@shapeshiftoss/types-v1.20.0) (2021-12-17) ### Features * implement yearn market service ([#273](#273)) ([d999850](d999850))
🎉 This PR is included in version @shapeshiftoss/types-v1.20.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
shapeshift-ci-bot
pushed a commit
that referenced
this pull request
Dec 17, 2021
# [@shapeshiftoss/asset-service-v1.10.0](https://github.com/shapeshift/lib/compare/@shapeshiftoss/asset-service-v1.9.0...@shapeshiftoss/asset-service-v1.10.0) (2021-12-17) ### Features * implement yearn market service ([#273](#273)) ([d999850](d999850))
🎉 This PR is included in version @shapeshiftoss/asset-service-v1.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
shapeshift-ci-bot
pushed a commit
that referenced
this pull request
Dec 17, 2021
# [@shapeshiftoss/market-service-v1.7.0](https://github.com/shapeshift/lib/compare/@shapeshiftoss/market-service-v1.6.0...@shapeshiftoss/market-service-v1.7.0) (2021-12-17) ### Features * implement yearn market service ([#273](#273)) ([d999850](d999850))
🎉 This PR is included in version @shapeshiftoss/market-service-v1.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
sdmg15
pushed a commit
to sdmg15/lib
that referenced
this pull request
Jan 6, 2022
* initial yearn market service template * wip - add findAll to YearnMarketService * wip - add yearn sdk * implement findAll for Yearn market service * got findByCaip19 working * feat: got happy path for yearn market historical data. * add error handling to market service manager * fix: updated generated assets file * added try catch around price history * fixed imports * fixed linting * changed find all type from pages and per page to count * typed gql vault response * fixed up type * removed commented code and changed splice to slice * Fixed coingecko tests * add mock yearn data * Got yearn tests working * fixed tests * wrote tests for market service manager * removed comments * restructured market service index file * fixed lint * put in process.env * fixed typo * added null reference checks * Extracted out 6 to USDC_PRECISION const * add bn, bnOrZero to market service package * fix linter * using bnOrZero * fixed tests Co-authored-by: theoboldfrazier <[email protected]>
sdmg15
pushed a commit
to sdmg15/lib
that referenced
this pull request
Jan 6, 2022
# [@shapeshiftoss/types-v1.20.0](https://github.com/shapeshift/lib/compare/@shapeshiftoss/types-v1.19.1...@shapeshiftoss/types-v1.20.0) (2021-12-17) ### Features * implement yearn market service ([shapeshift#273](shapeshift#273)) ([d999850](shapeshift@d999850))
sdmg15
pushed a commit
to sdmg15/lib
that referenced
this pull request
Jan 6, 2022
# [@shapeshiftoss/asset-service-v1.10.0](https://github.com/shapeshift/lib/compare/@shapeshiftoss/asset-service-v1.9.0...@shapeshiftoss/asset-service-v1.10.0) (2021-12-17) ### Features * implement yearn market service ([shapeshift#273](shapeshift#273)) ([d999850](shapeshift@d999850))
sdmg15
pushed a commit
to sdmg15/lib
that referenced
this pull request
Jan 6, 2022
# [@shapeshiftoss/market-service-v1.7.0](https://github.com/shapeshift/lib/compare/@shapeshiftoss/market-service-v1.6.0...@shapeshiftoss/market-service-v1.7.0) (2021-12-17) ### Features * implement yearn market service ([shapeshift#273](shapeshift#273)) ([d999850](shapeshift@d999850))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #271