This repository has been archived by the owner on Apr 11, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ccc0e7
to
4a0b03f
Compare
Closed
d0024e8
to
c297278
Compare
f4f6037
to
90979a7
Compare
0xdef1cafe
commented
Sep 20, 2021
.github/workflows/release.yml
Outdated
push: | ||
branches: | ||
- main | ||
- semantic-release # REMOVE THIS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this before merging
0xdef1cafe
commented
Sep 20, 2021
90979a7
to
3fd210e
Compare
natven
previously approved these changes
Sep 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - defi to communicate branch strategy changes with the workstream and community members
3fd210e
to
c3eb910
Compare
c3eb910
to
c8074ea
Compare
natven
approved these changes
Sep 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - defi to communicate branch strategy changes with the workstream and community members
SterL
approved these changes
Sep 20, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a few things but gets us much closer to CI being setup for this repo.
main
, and the title will be the commit message. The PR title will be used to for the changelog, and to determine what type of release to do off ofmain
, and allows people to make whatever commits they want to their branch before PRing.commitlint
step on therelease
action onmain
- in the event that we sneak in a PR title that doesn't confirm CI will fail.Release
step on pushing (merging) tomain
. This usessemantic-release
and a bunch of plugins to do the followingCHANGELOG.md
filemain
See the
Checks
tab above, then theRelease
job, and theRelease
step for the output. This PR is running in dry run mode until we remove those checks and merge this tomain
.