Skip to content
This repository has been archived by the owner on Apr 11, 2023. It is now read-only.

fix: unbreak lib build #588

Merged
merged 2 commits into from
May 2, 2022
Merged

fix: unbreak lib build #588

merged 2 commits into from
May 2, 2022

Conversation

gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented May 2, 2022 •
edited
Loading

This unbreaks the yarn build step, which is currently broken in latest develop since e02a2f4:

image

  • update @shapeshiftoss/types to latest where needed
  • add missing tokens property in transformValidator return type
  • narrow down the adapter type to be ChainTypes.Ethereum vs. ChainTypes currently in investor-foxy. This gives it a proper T generic type that's passed down to various methods and solves many type errors. This also gives it typing parity with investor-yearn, where the typing is actually the correct narrowed down one:

    lib/packages/investor-yearn/src/api/api.ts

    Line 32 in bf5aa33

    adapter: ChainAdapter<ChainTypes.Ethereum>

    lib/packages/investor-yearn/src/api/api.ts

    Line 40 in bf5aa33

    public adapter: ChainAdapter<ChainTypes.Ethereum>
  • add ChainAdapter<ChainTypes.Ethereum> type casting to adapter property in FoxyApi args. Until we narrow down the types in chain-adapters byChainId, that's probably the easiest way to go
  • bump @shapeshiftoss/chain-adapters to ^2.13.0 in investor-yearn for version parity with investor-foxy
  • import correct, non-namespaced path in packages/market-service/src/market-service-manager.ts: import { FindAllMarketArgs } from '@shapeshiftoss/types/src' -> import { FindAllMarketArgs } from '@shapeshiftoss/types'

    lib/packages/market-service/src/market-service-manager.ts

    Line 9 in 597dc6e

    import { FindAllMarketArgs } from '@shapeshiftoss/types/src'

@gomesalexandre gomesalexandre marked this pull request as ready for review May 2, 2022 11:43
@gomesalexandre gomesalexandre requested review from a team and kaladinlight as code owners May 2, 2022 11:43
@gomesalexandre
Copy link
Contributor Author

@cjthompson Since this bumps deps to new major one, do we want this to be squashed to a BREAKING CHANGE: body?

@0xdef1cafe 0xdef1cafe merged commit bff0f3d into main May 2, 2022
@0xdef1cafe 0xdef1cafe deleted the unrug_lib branch May 2, 2022 15:42
shapeshift-ci-bot pushed a commit that referenced this pull request May 2, 2022
@semantic-release-bot
chore(release): 2.4.2 [skip ci]
cec9492 
# [@shapeshiftoss/asset-service-v2.4.2](https://github.com/shapeshift/lib/compare/@shapeshiftoss/asset-service-v2.4.1...@shapeshiftoss/asset-service-v2.4.2) (2022-05-02)

### Bug Fixes

* unbreak lib build ([#588](#588)) ([bff0f3d](bff0f3d))
* vscode tsconfig errors ([#577](#577)) ([50138d0](50138d0))
@shapeshift-ci-bot
Copy link
Member

🎉 This PR is included in version @shapeshiftoss/asset-service-v2.4.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

shapeshift-ci-bot pushed a commit that referenced this pull request May 2, 2022
@semantic-release-bot
chore(release): 2.13.5 [skip ci]
8664b46 
# [@shapeshiftoss/chain-adapters-v2.13.5](https://github.com/shapeshift/lib/compare/@shapeshiftoss/chain-adapters-v2.13.4...@shapeshiftoss/chain-adapters-v2.13.5) (2022-05-02)

### Bug Fixes

* unbreak lib build ([#588](#588)) ([bff0f3d](bff0f3d))
* vscode tsconfig errors ([#577](#577)) ([50138d0](50138d0))
@shapeshift-ci-bot
Copy link
Member

🎉 This PR is included in version @shapeshiftoss/chain-adapters-v2.13.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

shapeshift-ci-bot pushed a commit that referenced this pull request May 2, 2022
@semantic-release-bot
chore(release): 1.4.2 [skip ci]
12458c6 
# [@shapeshiftoss/investor-foxy-v1.4.2](https://github.com/shapeshift/lib/compare/@shapeshiftoss/investor-foxy-v1.4.1...@shapeshiftoss/investor-foxy-v1.4.2) (2022-05-02)

### Bug Fixes

* unbreak lib build ([#588](#588)) ([bff0f3d](bff0f3d))
* vscode tsconfig errors ([#577](#577)) ([50138d0](50138d0))
@shapeshift-ci-bot
Copy link
Member

🎉 This PR is included in version @shapeshiftoss/investor-foxy-v1.4.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

shapeshift-ci-bot pushed a commit that referenced this pull request May 2, 2022
@semantic-release-bot
chore(release): 1.4.6 [skip ci]
6de8de5 
# [@shapeshiftoss/investor-yearn-v1.4.6](https://github.com/shapeshift/lib/compare/@shapeshiftoss/investor-yearn-v1.4.5...@shapeshiftoss/investor-yearn-v1.4.6) (2022-05-02)

### Bug Fixes

* unbreak lib build ([#588](#588)) ([bff0f3d](bff0f3d))
* vscode tsconfig errors ([#577](#577)) ([50138d0](50138d0))
@shapeshift-ci-bot
Copy link
Member

🎉 This PR is included in version @shapeshiftoss/investor-yearn-v1.4.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

shapeshift-ci-bot pushed a commit that referenced this pull request May 2, 2022
@semantic-release-bot
chore(release): 2.2.1 [skip ci]
afa0504 
# [@shapeshiftoss/market-service-v2.2.1](https://github.com/shapeshift/lib/compare/@shapeshiftoss/market-service-v2.2.0...@shapeshiftoss/market-service-v2.2.1) (2022-05-02)

### Bug Fixes

* unbreak lib build ([#588](#588)) ([bff0f3d](bff0f3d))
* vscode tsconfig errors ([#577](#577)) ([50138d0](50138d0))
@shapeshift-ci-bot
Copy link
Member

🎉 This PR is included in version @shapeshiftoss/market-service-v2.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

shapeshift-ci-bot pushed a commit that referenced this pull request May 2, 2022
@semantic-release-bot
chore(release): 3.0.1 [skip ci]
710a767 
# [@shapeshiftoss/swapper-v3.0.1](https://github.com/shapeshift/lib/compare/@shapeshiftoss/swapper-v3.0.0...@shapeshiftoss/swapper-v3.0.1) (2022-05-02)

### Bug Fixes

* unbreak lib build ([#588](#588)) ([bff0f3d](bff0f3d))
* vscode tsconfig errors ([#577](#577)) ([50138d0](50138d0))
@shapeshift-ci-bot
Copy link
Member

🎉 This PR is included in version @shapeshiftoss/swapper-v3.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cjthompson cjthompson cjthompson approved these changes

@0xdef1cafe 0xdef1cafe 0xdef1cafe approved these changes

@kaladinlight kaladinlight Awaiting requested review from kaladinlight

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gomesalexandre @shapeshift-ci-bot @cjthompson @0xdef1cafe