This repository was archived by the owner on Apr 11, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 54
feat(swapper): refactor + genericize 0x swapper to support any EVM #850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaladinlight
reviewed
Jul 5, 2022
kaladinlight
reviewed
Jul 5, 2022
kaladinlight
reviewed
Jul 5, 2022
packages/swapper/src/swappers/zrx/getZrxTradeQuote/getZrxTradeQuote.test.ts
Outdated
Show resolved
Hide resolved
kaladinlight
reviewed
Jul 5, 2022
packages/swapper/src/swappers/zrx/getZrxTradeQuote/getZrxTradeQuote.test.ts
Outdated
Show resolved
Hide resolved
kaladinlight
reviewed
Jul 5, 2022
kaladinlight
reviewed
Jul 5, 2022
kaladinlight
reviewed
Jul 5, 2022
kaladinlight
reviewed
Jul 6, 2022
kaladinlight
reviewed
Jul 6, 2022
kaladinlight
reviewed
Jul 6, 2022
kaladinlight
reviewed
Jul 6, 2022
probably want to hit this hardcode while we are in the area |
5 tasks
5 tasks
b9ee9ca
to
04fbc8d
Compare
kaladinlight
approved these changes
Jul 7, 2022
0xdef1cafe
reviewed
Jul 7, 2022
0xdef1cafe
approved these changes
Jul 7, 2022
shapeshift-ci-bot
pushed a commit
that referenced
this pull request
Jul 7, 2022
# [@shapeshiftoss/swapper-v8.0.0](https://github.com/shapeshift/lib/compare/@shapeshiftoss/swapper-v7.9.1...@shapeshiftoss/swapper-v8.0.0) (2022-07-07) ### Features * **swapper:** refactor + genericize 0x swapper to support any EVM ([#850](#850)) ([094c684](094c684)) ### BREAKING CHANGES * **swapper:** SwapperType has been removed from @shapeshiftoss/types and will instead need to be imported from @shaperhiftoss/swapper. * fix: correct import * chore: remove redundant swapperType arg * chore: update tests for removed arg * fix: CLI tool and docs * feat: discriminate swapperType by chainId * chore: nest swapper-specific types * Revert "chore: remove deprecated getSwapper method" This reverts commit 5591f9e. * fix: reversion issues * chore: improve types * chore: use EvmSupportedChainIds * chore: improve generics * propagate generics through and add extra types Co-authored-by: kaladinlight <[email protected]>
🎉 This PR is included in version @shapeshiftoss/swapper-v8.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
shapeshift-ci-bot
pushed a commit
that referenced
this pull request
Jul 7, 2022
# [@shapeshiftoss/types-v7.0.0](https://github.com/shapeshift/lib/compare/@shapeshiftoss/types-v6.3.0...@shapeshiftoss/types-v7.0.0) (2022-07-07) ### Features * **swapper:** refactor + genericize 0x swapper to support any EVM ([#850](#850)) ([094c684](094c684)) ### BREAKING CHANGES * **swapper:** SwapperType has been removed from @shapeshiftoss/types and will instead need to be imported from @shaperhiftoss/swapper. * fix: correct import * chore: remove redundant swapperType arg * chore: update tests for removed arg * fix: CLI tool and docs * feat: discriminate swapperType by chainId * chore: nest swapper-specific types * Revert "chore: remove deprecated getSwapper method" This reverts commit 5591f9e. * fix: reversion issues * chore: improve types * chore: use EvmSupportedChainIds * chore: improve generics * propagate generics through and add extra types Co-authored-by: kaladinlight <[email protected]>
🎉 This PR is included in version @shapeshiftoss/types-v7.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KnownChainIds
swapperType
argument fromaddSwapper
methodCloses: