Skip to content
This repository was archived by the owner on Apr 11, 2023. It is now read-only.

feat(swapper): refactor + genericize 0x swapper to support any EVM #850

Merged
merged 32 commits into from
Jul 7, 2022

Conversation

0xApotheosis
Copy link
Member

@0xApotheosis 0xApotheosis commented Jul 1, 2022

  • Makes the existing 0x swapper generic, allowing it to support all 0x-supported EVM chains, including Avalanche
  • Improves Swapper types
  • Propagates use of KnownChainIds
  • Removes redundant swapperType argument from addSwapper method

Closes:

@0xdef1cafe 0xdef1cafe linked an issue Jul 5, 2022 that may be closed by this pull request
@kaladinlight
Copy link
Contributor

@0xApotheosis 0xApotheosis changed the title feat(swapper): genericize the 0x swapper to support any EVM feat(swapper): refactor + genericize 0x swapper to support any EVM Jul 7, 2022
@0xApotheosis 0xApotheosis marked this pull request as ready for review July 7, 2022 10:01
@0xApotheosis 0xApotheosis requested a review from a team as a code owner July 7, 2022 10:01
@0xApotheosis 0xApotheosis requested a review from kaladinlight July 7, 2022 10:01
@0xdef1cafe 0xdef1cafe merged commit 094c684 into main Jul 7, 2022
@0xdef1cafe 0xdef1cafe deleted the avalanche-swapper branch July 7, 2022 20:10
shapeshift-ci-bot pushed a commit that referenced this pull request Jul 7, 2022
# [@shapeshiftoss/swapper-v8.0.0](https://github.com/shapeshift/lib/compare/@shapeshiftoss/swapper-v7.9.1...@shapeshiftoss/swapper-v8.0.0) (2022-07-07)

### Features

* **swapper:** refactor + genericize 0x swapper to support any EVM ([#850](#850)) ([094c684](094c684))

### BREAKING CHANGES

* **swapper:** SwapperType has been removed from @shapeshiftoss/types and will instead need to be imported from @shaperhiftoss/swapper.

* fix: correct import

* chore: remove redundant swapperType arg

* chore: update tests for removed arg

* fix: CLI tool and docs

* feat: discriminate swapperType by chainId

* chore: nest swapper-specific types

* Revert "chore: remove deprecated getSwapper method"

This reverts commit 5591f9e.

* fix: reversion issues

* chore: improve types

* chore: use EvmSupportedChainIds

* chore: improve generics

* propagate generics through and add extra types

Co-authored-by: kaladinlight <[email protected]>
@shapeshift-ci-bot
Copy link
Member

🎉 This PR is included in version @shapeshiftoss/swapper-v8.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

shapeshift-ci-bot pushed a commit that referenced this pull request Jul 7, 2022
# [@shapeshiftoss/types-v7.0.0](https://github.com/shapeshift/lib/compare/@shapeshiftoss/types-v6.3.0...@shapeshiftoss/types-v7.0.0) (2022-07-07)

### Features

* **swapper:** refactor + genericize 0x swapper to support any EVM ([#850](#850)) ([094c684](094c684))

### BREAKING CHANGES

* **swapper:** SwapperType has been removed from @shapeshiftoss/types and will instead need to be imported from @shaperhiftoss/swapper.

* fix: correct import

* chore: remove redundant swapperType arg

* chore: update tests for removed arg

* fix: CLI tool and docs

* feat: discriminate swapperType by chainId

* chore: nest swapper-specific types

* Revert "chore: remove deprecated getSwapper method"

This reverts commit 5591f9e.

* fix: reversion issues

* chore: improve types

* chore: use EvmSupportedChainIds

* chore: improve generics

* propagate generics through and add extra types

Co-authored-by: kaladinlight <[email protected]>
@shapeshift-ci-bot
Copy link
Member

🎉 This PR is included in version @shapeshiftoss/types-v7.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@0xdef1cafe 0xdef1cafe linked an issue Jul 8, 2022 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor swapper Genericize zrx swapper for Avalanche
4 participants