refactor: tidy-up codebase

packages/chain-adapters/src/evm/EVMBaseAdapter.ts

@@ -1,6 +1,10 @@
 import { AssetId, ChainId, toAssetId } from '@shapeshiftoss/caip'
-import { ETHSignMessage } from '@shapeshiftoss/hdwallet-core'
-import { bip32ToAddressNList, ETHSignTx, ETHWallet } from '@shapeshiftoss/hdwallet-core'
+import {
+  bip32ToAddressNList,
+  ETHSignMessage,
+  ETHSignTx,
+  ETHWallet
+} from '@shapeshiftoss/hdwallet-core'
 import { BIP44Params, KnownChainIds } from '@shapeshiftoss/types'
 import * as unchained from '@shapeshiftoss/unchained-client'
 import WAValidator from 'multicoin-address-validator'
@@ -63,7 +67,7 @@ export abstract class EVMBaseAdapter<T extends EVMChainIds> implements IChainAda
 
   static defaultBIP44Params: BIP44Params
 
-  constructor(args: EVMBaseAdapterArgs) {
+  protected constructor(args: EVMBaseAdapterArgs) {
     EVMBaseAdapter.defaultBIP44Params = (<typeof EVMBaseAdapter>this.constructor).defaultBIP44Params
 
     this.supportedChainIds = args.supportedChainIds

packages/investor-foxy/src/api/foxy-types.ts

@@ -46,11 +46,6 @@ export type TxInput = {
 
 export type TxInputWithoutAmount = Pick<TxInput, Exclude<keyof TxInput, 'amountDesired'>>
 
-export type TxInputWithoutAmountUnsigned = Pick<
-  TxInputWithoutAmount,
-  Exclude<keyof TxInputWithoutAmount, 'wallet' | 'dryRun'>
->
-
 export type TxInputWithoutAmountAndWallet = Pick<
   TxInputWithoutAmount,
   Exclude<keyof TxInputWithoutAmount, 'wallet'>
@@ -141,13 +136,6 @@ export type Recipient = {
   amount: string
 }
 
-export type EstimateClaimFromTokemak = TxInputWithoutAmountAndWallet & {
-  recipient: Recipient
-  v: number
-  r: string
-  s: string
-}
-
 export type RebaseEvent = {
   epoch: string
   blockNumber: number

packages/investor-foxy/src/constants/enums.ts

@@ -1,7 +1,3 @@
-export enum DefiProvider {
-  Foxy = 'foxy'
-}
-
 export enum DefiType {
   TokenStaking = 'token-staking'
 }

packages/market-service/src/coingecko/coingecko-types.ts

@@ -1,5 +1,3 @@
-export type CoinGeckoMarketCapNoId = Omit<CoinGeckoMarketCap, 'id'>
-
 export type CoinGeckoMarketData = {
   current_price: Record<string, number>
   market_cap: Record<string, number>

packages/market-service/src/fiat-market-service-manager.ts

@@ -15,7 +15,6 @@ export const findByFiatSymbol = async ({ symbol }: FiatMarketDataArgs) => {
       result = await FiatMarketProviders[i].findByFiatSymbol({ symbol })
     } catch (e) {
       // Swallow error, not every fiat will be with every provider.
-      continue
     }
   }
   if (!result) return null
@@ -33,7 +32,6 @@ export const findPriceHistoryByFiatSymbol: FiatPriceHistoryType = async ({
       result = await FiatMarketProviders[i].findPriceHistoryByFiatSymbol({ symbol, timeframe })
     } catch (e) {
       // Swallow error, not every fiat will be with every provider.
-      continue
     }
   }
   if (!result) return []

packages/market-service/src/market-service-manager.ts

@@ -1,12 +1,12 @@
 import { JsonRpcProvider } from '@ethersproject/providers'
 import {
+  FindAllMarketArgs,
   HistoryData,
   MarketCapResult,
   MarketData,
   MarketDataArgs,
   PriceHistoryArgs
 } from '@shapeshiftoss/types'
-import { FindAllMarketArgs } from '@shapeshiftoss/types'
 import { Yearn } from '@yfi/sdk'
 
 import { MarketService } from './api'
@@ -79,7 +79,6 @@ export class MarketServiceManager {
         result = await this.marketProviders[i].findByAssetId({ assetId })
       } catch (e) {
         // Swallow error, not every asset will be with every provider.
-        continue
       }
     }
     if (!result) return null
@@ -97,7 +96,6 @@ export class MarketServiceManager {
         result = await this.marketProviders[i].findPriceHistoryByAssetId({ assetId, timeframe })
       } catch (e) {
         // Swallow error, not every asset will be with every provider.
-        continue
       }
     }
     if (!result) return []