This repository was archived by the owner on Apr 11, 2023. It is now read-only.
feat(swapper): remove deprecated getSwapper method #853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gomesalexandre
previously approved these changes
Jul 2, 2022
gomesalexandre
approved these changes
Jul 3, 2022
kaladinlight
reviewed
Jul 5, 2022
| '[validateSwapper] - invalid swapper instance' | ||
| ) | ||
| expect(swapper.swappers.get(SwapperType.Thorchain)).toBeInstanceOf(ThorchainSwapper) | ||
| expect(swapper.swappers.get(SwapperType.Zrx)).toBeInstanceOf(ZrxSwapper) |
There was a problem hiding this comment.
Suggested change
| expect(swapper.swappers.get(SwapperType.Zrx)).toBeInstanceOf(ZrxSwapper) |
|
This feels a little weird to me having |
|
as discussed - let's talk to the manager through it's interfaces it exposes, rather than the raw map of swappers |
|
@0xApotheosis plz undeprecate this (lol) as to not cause future confusion |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getSwapperis deprecated, and is now only used in tests.This PR removes it and uses
Map.prototype.get()in the tests instead.