fix: properly convert osmosis legacy transactions #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 22, 2023
gomesalexandre
approved these changes
Feb 22, 2023
There was a problem hiding this comment.
Untested but cross-checked against https://pkg.go.dev/github.com/osmosis-labs/osmosis/x/gamm/types / https://docs.osmosis.zone/osmosis-core/modules/gamm/ / https://docs.osmosis.zone/osmosis-core/modules/lockup/, LGTM
|
@kaladinlight - I like the type union over introducing a new type here. The PR was merged as-is about half an hour ago - I'll open a new PR with the requested changes before propagating the changes from this PR upstream. |
|
@kaladinlight @gomesalexandre - comments addressed in #18 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parse_legacy_tx_formatagnostic tomsg/msgs