-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dead UI Link ETH about section #2167
Comments
This is not a bug, "Link removed for security" is a feature that was implemented in #1107 This description is coming from With the current architecture, if we want to make the link work, we will have to add it as an overriden description, basically copying and pasting all the copies from the API request above and change the links to be in markdown format. Authored shapeshift/lib#884 for it. |
@shapeshift/product Please have a look at the screenshots in the PR - This will do for now as far as fixing links goes, but we might want to iterate on this with our own in-house, improved description, as it's a bit outdated. |
yeah I think we can remove the link. I'll have @decentralized-j take a pass at updating the copy there. There's also a link at the bottom of that block of copy that should be removed. |
Overview
In the about section on the ETH account and asset page, there's a dead link pop up that appears when you hover over the underlined text, "smart contract platform."
References and additional details
Acceptance Criteria
Either the hyperlink should be added to the "smart contract platform" text in the about section or the dead link pop up should be removed. Not sure what the expected behavior should be here
Need By Date
No response
Screenshots/Mockups
Estimated effort
No response
The text was updated successfully, but these errors were encountered: