Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dead UI Link ETH about section #2167

Closed
wesleygravess opened this issue Jul 14, 2022 · 3 comments · Fixed by #2176
Closed

Dead UI Link ETH about section #2167

wesleygravess opened this issue Jul 14, 2022 · 3 comments · Fixed by #2176
Labels
needs engineering Requires engineering input before bounty

Comments

@wesleygravess
Copy link

Overview

In the about section on the ETH account and asset page, there's a dead link pop up that appears when you hover over the underlined text, "smart contract platform."

References and additional details

  1. go to app.shapeshift
  2. log in with your wallet of choice
  3. go to the ETH accounts or asset page.
  4. go to the about section
  5. hover over the underlined text, "smart contract platform"
  6. noticed the dead link pop up that appears

Acceptance Criteria

Either the hyperlink should be added to the "smart contract platform" text in the about section or the dead link pop up should be removed. Not sure what the expected behavior should be here

Need By Date

No response

Screenshots/Mockups

Screenshot 2022-07-14 124250

Estimated effort

No response

@wesleygravess wesleygravess added the needs product Requires product input before bounty label Jul 14, 2022
@gomesalexandre
Copy link
Contributor

gomesalexandre commented Jul 18, 2022

This is not a bug, "Link removed for security" is a feature that was implemented in #1107

This description is coming from https://api.coingecko.com/api/v3/coins/ethereum and we do not currently allow links for externally-fetched descriptions, for security purposes.

With the current architecture, if we want to make the link work, we will have to add it as an overriden description, basically copying and pasting all the copies from the API request above and change the links to be in markdown format.

Authored shapeshift/lib#884 for it.
Globalization will only be responsible for translating to other languages, the base copy should be provided by product if we want one @firebomb1 Happy to update the copy if globalization provides another, but for now that will make the links available.

@gomesalexandre
Copy link
Contributor

@shapeshift/product Please have a look at the screenshots in the PR - This will do for now as far as fixing links goes, but we might want to iterate on this with our own in-house, improved description, as it's a bit outdated.

Repository owner moved this from Backlog to Done in ShapeShift Dashboard Jul 18, 2022
@DiggyDiggy2
Copy link
Contributor

DiggyDiggy2 commented Jul 19, 2022

yeah I think we can remove the link. I'll have @decentralized-j take a pass at updating the copy there. There's also a link at the bottom of that block of copy that should be removed.

@DiggyDiggy2 DiggyDiggy2 added needs engineering Requires engineering input before bounty and removed needs product Requires product input before bounty labels Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs engineering Requires engineering input before bounty
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants