Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump lib packages to latest #2176

Merged
merged 4 commits into from
Jul 18, 2022
Merged

feat: bump lib packages to latest #2176

merged 4 commits into from
Jul 18, 2022

Conversation

gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Jul 18, 2022

Description

This bumps investor-foxy, investor-yearn, market-service, and hdwallet packages to latest.

Included releases:

Notice

  • Have you followed the guidelines in our Contributing guide?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Pull Request Type

  • 🐛 Bug fix (Non-breaking Change: Fixes an issue)
  • 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • 💅 New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

N/A

Risk

None. This brings no user-facing changes, all bumps are either isolated and/or not consumed in web yet.

Testing

  • yarn dev should work without webpack CLI/console errors, and the app should work with no regressions

Screenshots (if applicable)

@gomesalexandre gomesalexandre marked this pull request as ready for review July 18, 2022 18:31
@gomesalexandre gomesalexandre requested review from a team and 0xApotheosis as code owners July 18, 2022 18:31
0xApotheosis
0xApotheosis previously approved these changes Jul 18, 2022
Copy link
Member

@0xApotheosis 0xApotheosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a quick test locally, noticed no regressions.

Copy link
Member

@0xApotheosis 0xApotheosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gomesalexandre I am getting a diff when running yarn:

-"@shapeshiftoss/[email protected]", "@shapeshiftoss/[email protected]", "@shapeshiftoss/hdwallet-core@latest":
+"@shapeshiftoss/[email protected]", "@shapeshiftoss/hdwallet-core@latest":
   version "1.25.0"
   resolved "https://registry.yarnpkg.com/@shapeshiftoss/hdwallet-core/-/hdwallet-core-1.25.0.tgz#97b4e29f124ef6600f182af33e620b10bb4b0e60"
   integrity sha512-o4o9ww4ux7NmoBIjT3AlP6gmxKzRHvyfxpkVGuaM5bHuPa44GItO5duZwK9s38QqC0EX4z8USG1/44E2e+YaXw==
@@ -3841,7 +3841,7 @@
     rxjs "^6.4.0"
     type-assertions "^1.1.0"

-"@shapeshiftoss/hdwallet-core@^1.27.0":
+"@shapeshiftoss/[email protected]", "@shapeshiftoss/hdwallet-core@^1.27.0":
   version "1.27.0"
   resolved "https://registry.yarnpkg.com/@shapeshiftoss/hdwallet-core/-/hdwallet-core-1.27.0.tgz#63ab356040f00980fbbc5d60435a7a8ea697fc7b"
   integrity sha512-NmucwcYTB3uq2SmsWK6rg+bywpDDn6CFAiiYkDR52CxSxxfKSWNkV0Pq+ZeHTvd5NZ9VGL2fft4WXGMjQ0fyzA==

@gomesalexandre
Copy link
Contributor Author

@gomesalexandre I am getting a diff when running yarn:

-"@shapeshiftoss/[email protected]", "@shapeshiftoss/[email protected]", "@shapeshiftoss/hdwallet-core@latest":
+"@shapeshiftoss/[email protected]", "@shapeshiftoss/hdwallet-core@latest":
   version "1.25.0"
   resolved "https://registry.yarnpkg.com/@shapeshiftoss/hdwallet-core/-/hdwallet-core-1.25.0.tgz#97b4e29f124ef6600f182af33e620b10bb4b0e60"
   integrity sha512-o4o9ww4ux7NmoBIjT3AlP6gmxKzRHvyfxpkVGuaM5bHuPa44GItO5duZwK9s38QqC0EX4z8USG1/44E2e+YaXw==
@@ -3841,7 +3841,7 @@
     rxjs "^6.4.0"
     type-assertions "^1.1.0"

-"@shapeshiftoss/hdwallet-core@^1.27.0":
+"@shapeshiftoss/[email protected]", "@shapeshiftoss/hdwallet-core@^1.27.0":
   version "1.27.0"
   resolved "https://registry.yarnpkg.com/@shapeshiftoss/hdwallet-core/-/hdwallet-core-1.27.0.tgz#63ab356040f00980fbbc5d60435a7a8ea697fc7b"
   integrity sha512-NmucwcYTB3uq2SmsWK6rg+bywpDDn6CFAiiYkDR52CxSxxfKSWNkV0Pq+ZeHTvd5NZ9VGL2fft4WXGMjQ0fyzA==

Interesting, I ran yarn upgrade-interactive --latest, that could be why, since package.json has been updated in the meantime. Updated yarn.lock in c22b766

Copy link
Collaborator

@0xdef1cafe 0xdef1cafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yee this is happy with no lockfile changes

@0xdef1cafe 0xdef1cafe merged commit 24ed631 into develop Jul 18, 2022
@0xdef1cafe 0xdef1cafe deleted the bump_lib_packages branch July 18, 2022 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dead UI Link ETH about section
3 participants