Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DeFI - View position not available after staking #908

Closed
2 tasks done
gomesalexandre opened this issue Feb 3, 2022 · 16 comments
Closed
2 tasks done

DeFI - View position not available after staking #908

gomesalexandre opened this issue Feb 3, 2022 · 16 comments
Assignees
@gomesalexandre
Labels
needs operations

Comments

@gomesalexandre
Copy link
Contributor

gomesalexandre commented Feb 3, 2022 •
edited
Loading

Overview

After staking in some vault and clicking "View Position", DeFI overview doesn't show the position.

Steps to reproduce:

  1. Stake some asset in DeFi vault
  2. Wait for Metamask confirmation
  3. On the last step of the modal, click "View Position"

Expected:

  • No full page reload is necessary for my position to appear
  • I can view my position, it is available as a card

Actual:

  • My position is not there
  • A full page reload is necessary for it to appear

References and additional details

Acceptance Criteria

As a user, my new/updated staking position should appear:

  • Overview card is updated to reflect the new/updated position
  • Earn row is updated to reflect the new/updated position
  • The deposit modal is updated, so that the amount is deducted from the amount available to deposit, and added to the amount available to unstake
  • Account balance is updated to reflect the new/updated position

Need By Date

No response

Screenshots/Mockups

No response

Ownership

  • If my bounty needs engineering or needs product I have added the respective labels on the right
  • As the sponsor of this bounty I will review the changes in a preview environment (ops/product) or review the PR (engineering)

Estimated effort

No response

Sponsor / Stakeholder

@gomesalexandre (gomes on Discord)

Bounty Hunters

  • Join our discord
  • Include an expected timeline for you to complete work in the work plan when you apply for this bounty!
  • Please refer to this link for some basic info
  • Please do not start work on this issue until you are approved in Gitcoin.
@0xdef1cafe
Copy link
Collaborator

root cause is here #706

@0xean 0xean added the blocked label Feb 25, 2022
@0xdef1cafe 0xdef1cafe moved this to Backlog in ShapeShift Dashboard Feb 27, 2022
@0xean 0xean added needs engineering Requires engineering input before bounty and removed blocked labels Apr 20, 2022
@0xean
Copy link
Contributor

0xean commented Apr 20, 2022

@gomesalexandre to prep for bounty.

@gomesalexandre
Copy link
Contributor Author

5003516 might have fixed it.
I think you actually have to wait until the Tx is sent from the unchained Ws for the state to update accordingly everywhere, as per A/C.
Unfortunately Txs are very slow to be picked currently, so I'll try to reproduce it again later.

@gomesalexandre
Copy link
Contributor Author

@0xean I got the confirmation from @tshifty this is still happening currently despite the changes in 34a1785
Investigated this one locally and by just reverse engineering it and without knowing the root cause, it's hard to give a time estimate to bounty it out.

Given the domain this is on, and the gas spikes currently, this might require quite a bit of testing funds. I'd suggest reserving it for community contributors, who have shown great knowledge of the DeFi section, rather than bountying it out.

@0xean
Copy link
Contributor

0xean commented Apr 21, 2022

@gomesalexandre - greatly appreciate the update and communications here. I will post it in discord to see if anyone wants to pick it up

@0xean 0xean removed the needs engineering Requires engineering input before bounty label Apr 21, 2022
@0xean
Copy link
Contributor

0xean commented Apr 21, 2022

Maybe we need a label for this type of issue.

@gomesalexandre gomesalexandre added the needs engineering Requires engineering input before bounty label May 10, 2022
@gomesalexandre
Copy link
Contributor Author

Added back the needs engineering tag since I'm spiking what needs to be done here.

@0xean
Copy link
Contributor

0xean commented May 18, 2022

@gomesalexandre - any updates to this one? potential bounty?

@gomesalexandre
Copy link
Contributor Author

@gomesalexandre - any updates to this one? potential bounty?

Let's keep it to core dev, this one can get quite costly in gas fees! Didn't manage to find the root cause but will take another look at it tomorrow.

@gomesalexandre
Copy link
Contributor Author

gomesalexandre commented May 19, 2022 •
edited
Loading

@tshifty I can't reproduce this one locally anymore. Tried with USDT Yearn vault staking and it properly adds the staking card from the Overview list after I deposit into a non-yet-active opportunity, and removes it when I withdraw all from one active opportunity.
From a code perspective, everything is reactive as it should, and we are properly reacting on new Txs -> balance update -> opportunities re-fetched/parsed.

@gomesalexandre gomesalexandre added needs operations and removed needs engineering Requires engineering input before bounty labels May 19, 2022
@Lychbot
Copy link

Lychbot commented May 27, 2022

Hey @gomesalexandre! sorry for the delay on this. But was able to stake (tried WETH in my case) ,clicked on 'View Position" but the card didn't appear on the Overview page. Had to refresh the page for it to show up.

@0xean
Copy link
Contributor

0xean commented Jun 15, 2022

@shapeshift/operations will attempt to repro again before we close this one.

@MBMaria
Copy link

MBMaria commented Jun 15, 2022

Card did not update automatically once selecting "view position". Had to do a refresh to see the updated balance,

@0xdef1cafe
Copy link
Collaborator

@DiggyDiggy2 tagging as requested

@0xdef1cafe
Copy link
Collaborator

few things have happened since this was last looked at

  • we we're indexing yearn tx's wrong, and has since been fixed
  • websocket reconnection logic is in and fixes a lot of these type of issues
  • there are significant changes about to go into the whole defi section in feat: update defi ui  #2116

@shapeshift/operations can you plz retest after #2116 is merged

@Lychbot
Copy link

Lychbot commented Jul 25, 2022

@0xdef1cafe saw 2116 is merged. position is there without doing a full reload. LGTM

Repository owner moved this from Backlog to Done in ShapeShift Dashboard Jul 27, 2022
kaladinlight pushed a commit that referenced this issue Apr 7, 2023
@gomesalexandre
feat(caip): remove getFeeAssetIdFromAssetId / chainIdToAssetId (#908)
d5cfda5 
* feat(caip): remove getFeeAssetIdFromAssetId / chainIdToAssetId

* chore(caip): import chainId caip exports relatively

* chore: remove feeAssetId assignation / check in getTradeQuote
kaladinlight pushed a commit that referenced this issue Apr 7, 2023
@semantic-release-bot
chore(release): 6.8.0 [skip ci]
0c5c1b7 
# [@shapeshiftoss/caip-v6.8.0](https://github.com/shapeshift/lib/compare/@shapeshiftoss/caip-v6.7.1...@shapeshiftoss/caip-v6.8.0) (2022-08-01)

### Features

* **caip:** remove getFeeAssetIdFromAssetId / chainIdToAssetId ([#908](shapeshift/lib#908)) ([d5cfda5](shapeshift/lib@d5cfda5))
kaladinlight pushed a commit that referenced this issue Apr 7, 2023
@semantic-release-bot
chore(release): 9.3.0 [skip ci]
a3bee48 
# [@shapeshiftoss/swapper-v9.3.0](https://github.com/shapeshift/lib/compare/@shapeshiftoss/swapper-v9.2.3...@shapeshiftoss/swapper-v9.3.0) (2022-08-01)

### Features

* **caip:** remove getFeeAssetIdFromAssetId / chainIdToAssetId ([#908](shapeshift/lib#908)) ([d5cfda5](shapeshift/lib@d5cfda5))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gomesalexandre gomesalexandre

Labels
needs operations
Projects
ShapeShift Dashboard
Archived in project
Milestone
No milestone
Development

No branches or pull requests
5 participants
@0xean @gomesalexandre @Lychbot @0xdef1cafe @MBMaria