feat: fiat currencies support for application #1337
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
9399d97
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a4048c3f.web-29e.pages.dev |
|
@stackedq You might want to mergefix this, currently there are 27 conflicted files |
|
@gomesalexandre yeah, I'm actually waiting for a architectural review from @0xdef1cafe. |
|
closing in favor of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Blocked by: shapeshift/lib#495
also needs: #1342 for tests to pass.WIP: adding support for top 20 fiat currencies other than USD
Notice
Pull Request Type
Issue (if applicable)
Risk
Sending crypto with the amount chosen in fiat is not tested yet... so test it at your own risk (there probably will be a small difference in the fiat amount).
Testing
Open up the settings modal and change your currency to the 20 options available,
all of the prices in the app should respect the chosen fiat.
Screenshots (if applicable)